Closed Bug 358015 Opened 13 years ago Closed 13 years ago

Release notes can't be opened from source viewer/bookmarks manager

Categories

(Firefox :: Menus, defect)

2.0 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 2

People

(Reporter: zeniko, Assigned: zeniko)

Details

(Keywords: verified1.8.1.1)

Attachments

(1 file)

... because openReleaseNotes from chrome://browser/content/utilityOverlay.js depends on formatURL from chrome://browser/content/browser.js - which however isn't included in all the same places.
Attached patch fixSplinter Review
This patch cleans up openReleaseNotes and moves the relevant URL formatting code directly into that function.

And we might want to consider a simple fix like this for Firefox 2.0.0.1 as well (Bookmarks Manager and DOMi are affected as well - don't know about the "hidden window" though).
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #243512 - Flags: review?(mano)
Summary: Release notes can't be opened from source viewer → Release notes can't be opened from source viewer/bookmarks manager
Hidden window and macBrowsrOverlay are fine btw.
Whiteboard: [checkin needed]
Version: Trunk → 2.0 Branch
mozilla/browser/base/content/utilityOverlay.js 	1.45
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox 3 alpha1
Flags: blocking1.8.1.1?
Comment on attachment 243512 [details] [diff] [review]
fix

Drivers: Low risk patch to make the "Release Notes" menu entry actually do something for View Source/DOM Inspector/Bookmarks Manager. Baking since 10/28.
Attachment #243512 - Flags: approval1.8.1.1?
Flags: blocking1.8.1.1? → blocking1.8.1.1+
Comment on attachment 243512 [details] [diff] [review]
fix

Approved for 1.8.1 branch, a=jay for drivers.  Please land asap.  Thanks!
Attachment #243512 - Flags: approval1.8.1.1? → approval1.8.1.1+
Whiteboard: [checkin needed (1.8 branch)]
mozilla/browser/base/content/utilityOverlay.js 	1.32.2.13
Keywords: fixed1.8.1.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: Firefox 3 alpha1 → Firefox 2
Verified Release Notes can be opened from bookmarks manager/source viewer using: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1pre) Gecko/20061129
BonEcho/2.0.0.1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.