358023 - Mingw build error in nsNotifyAddrListener.cpp

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Martijn Wargers (dead)]

I get a build error in current trunk builds:
\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8\"  -D_
MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /cygdrive/c/mozilla/mozilla/netwerk/system/wi
n32/nsNotifyAddrListener.cpp
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:58: error: `PIP
_ADAPTER_ADDRESSES' has not been declared
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:59: error: ISO
C++ forbids declaration of `parameter' with no type
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp: In member func
tion `DWORD nsNotifyAddrListener::CheckAdaptersAddresses()':
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:388: error: `GA
A_FLAG_SKIP_FRIENDLY_NAME' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:388: error: `GA
A_FLAG_SKIP_ANYCAST' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:389: error: `GA
A_FLAG_SKIP_MULTICAST' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:389: error: `GA
A_FLAG_SKIP_DNS_SERVER' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:396: warning: c
onverting to non-pointer type `int' from NULL
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:398: error: `PI
P_ADAPTER_ADDRESSES' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:398: error: exp
ected `;' before "addresses"
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:399: error: `ad
dresses' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:402: error: exp
ected `;' before "ptr"
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:405: error: `pt
r' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:406: error: `If
OperStatusUp' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:407: error: `IF
_TYPE_SOFTWARE_LOOPBACK' was not declared in this scope
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:406: warning: u
nused variable 'IfOperStatusUp'
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:407: warning: u
nused variable 'IF_TYPE_SOFTWARE_LOOPBACK'
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:387: warning: u
nused variable 'flags'
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:388: warning: u
nused variable 'GAA_FLAG_SKIP_FRIENDLY_NAME'
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:388: warning: u
nused variable 'GAA_FLAG_SKIP_ANYCAST'
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:389: warning: u
nused variable 'GAA_FLAG_SKIP_MULTICAST'
c:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:389: warning: u
nused variable 'GAA_FLAG_SKIP_DNS_SERVER'
make[6]: *** [nsNotifyAddrListener.o] Error 1
make[6]: Leaving directory `/cygdrive/c/mozilla/mozilla/netwerk/system/win32'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/cygdrive/c/mozilla/mozilla/netwerk/system'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/c/mozilla/mozilla/netwerk'
make[3]: *** [libs_tier_necko] Error 2
make[3]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make[2]: *** [tier_necko] Error 2
make[2]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make: *** [alldep] Error 2

I think this build error happens because of the patch from bug 354984.

Comment 1

[David G King]

My MingW build has been dead for a while due to other problems, but I can confirm that this problem is now happening with gcc 3.4.5 under MingW/cygwin

Comment 2

[David G King]

I found that GAA_* are defined in iphlpapi.h under MinGW

#include <iphlpapi.h>

The PIP_* problems seemed to be due to my system not having WIN32_WINNT or WINSOCK2_H set correctly so the #if in iptypes.h was resolving as false. I didn't research this fully and just commented out the #if.

Comment 3

[Bengt-Erik Soderstrom]

I confirm exactly this happened today for me too. I thought maybe the MinGW build problems, which indeed have been present for a while, were solved with the proposed patch for bug 361340. But no, it was not.

Comment 4

[Martijn Wargers (dead)]

(In reply to comment #2)
> I found that GAA_* are defined in iphlpapi.h under MinGW
> 
> #include <iphlpapi.h>
> 
> The PIP_* problems seemed to be due to my system not having WIN32_WINNT or
> WINSOCK2_H set correctly so the #if in iptypes.h was resolving as false. I
> didn't research this fully and just commented out the #if.

Yeah, #include <iphlpapi.h> helps. Adding #define _WIN32_WINNT 0x0501 to iphlpapi.h and iptypes.h also helps.
And I need to add #define IF_TYPE_SOFTWARE_LOOPBACK 24 ( http://msdn2.microsoft.com/en-us/library/aa366320.aspx ) in nsNotifyAddListener.cpp to get it to compile again.
It seems like we sort of know where things go wrong. Now someone knowledgeable needs to make a good patch. Maybe Chris Seawood can help?

Comment 5

[cls]

Attachment: v1.0

This patch sets the default WINVER to 501 (XP?) for gcc (assumed w32api) builds.  I don't quite understand the purpose of that configure option given that we don't seem to disable features if building for a lower win32 version but I updated it to know about 501.

Comment 6

[Martijn Wargers (dead)]

Attachment: build error after applying patch

Thanks for the patch, Chris, but for some reason, I'm still getting a build error with my mingw build after applying the patch.
Maybe there is something wrong with my mingw setup?

Comment 7

[cls]

You need to run autoconf-2.13 after applying the patch.

Comment 8

[cls]

Checking in configure;
/cvsroot/mozilla/configure,v  <--  configure
new revision: 1.1751; previous revision: 1.1750
done
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1742; previous revision: 1.1741
done
Checking in netwerk/system/win32/nsNotifyAddrListener.cpp;
/cvsroot/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp,v  <--  nsNotifyAddrListener.cpp
new revision: 1.8; previous revision: 1.7
done

Comment 9

[Bengt-Erik Soderstrom]

Thanks guys for your all your help, but it seems that the #define mentioned in comment #4 is not there. This is what I got now:

Building deps for /cygdrive/d/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrL
istener.cpp
/cygdrive/d/mozilla/mozilla/build/cygwin-wrapper g++ -mno-cygwin -o nsNotifyAddr
Listener.o -c  -DMOZILLA_INTERNAL_API -DOSTYPE=\"WINNT5.1\" -DOSARCH=\"WINNT\" -
DBUILD_ID=2006112808 -DIMPL_NS_NET  -I../../../dist/include/xpcom -I../../../dis
t/include/string -I../../../dist/include/pref -I../../../dist/include   -I../../
../dist/include/necko -I../../../dist/include/nspr  -DMOZ_PNG_READ -DPNG_NO_MMX_
CODE -DMOZ_PNG_WRITE  -I../../../dist/sdk/include       -fno-rtti -fno-exception
s -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -
Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -mms-bitfie
lds -pipe  -DNDEBUG -DTRIMMED -O   -DWINVER=0x501 -D_WIN32_WINNT=0x501 -DX_DISPL
AY_MISSING=1 -DMOZILLA_VERSION=\"1.9a1\" -DMOZILLA_VERSION_U=1.9a1 -DHAVE_SNPRIN
TF=1 -D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -D
STDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DSTDC
_HEADERS=1 -DHAVE_DIRENT_H=1 -DHAVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H
=1 -DHAVE_MALLOC_H=1 -DHAVE_LIBM=1 -DNO_X11=1 -DMMAP_MISSES_WRITES=1 -DHAVE_STRE
RROR=1 -DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DVA_COPY=va_copy -DHAVE
_VA_COPY=1 -DMOZ_EMBEDDING_LEVEL_DEFAULT=1 -DMOZ_EMBEDDING_LEVEL_BASIC=1 -DMOZ_E
MBEDDING_LEVEL_MINIMAL=1 -DMOZ_PHOENIX=1 -DMOZ_BUILD_APP=browser -DMOZ_XUL_APP=1
 -DMOZ_DEFAULT_TOOLKIT=\"cairo-windows\" -DMOZ_THEBES=1 -DMOZ_CAIRO_GFX=1 -DMOZ_
DISTRIBUTION_ID=\"org.mozilla\" -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DMOZ_XP
INSTALL=1 -DMOZ_JSLOADER=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DMOZ_NO_XPCOM_O
BSOLETE=1 -DMOZ_XTF=1 -DMOZ_AIRBAG=1 -DMOZ_MATHML=1 -DMOZ_ENABLE_CANVAS=1 -DMOZ_
SVG=1 -DMOZ_SVG_FOREIGNOBJECT=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_FEEDS=1 -DMOZ
_STORAGE=1 -DMOZ_SAFE_BROWSING=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_LOGGING=1 -DHAVE__
_CXA_DEMANGLE=1 -DMOZ_USER_DIR=\"Mozilla\" -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1
 -DHAVE_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_RDF=1 -DMOZ_MORK=1 -
DMOZ_MORKREADER=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1 -DMOZILLA_LOCALE_V
ERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_VERSION=\"1.8
\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /cygdrive/d/mozilla/mozilla/netwerk/sy
stem/win32/nsNotifyAddrListener.cpp
d:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp: In member func
tion `DWORD nsNotifyAddrListener::CheckAdaptersAddresses()':
d:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:408: error: `IF
_TYPE_SOFTWARE_LOOPBACK' was not declared in this scope
d:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:408: warning: u
nused variable 'IF_TYPE_SOFTWARE_LOOPBACK'
d:/mozilla/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp:388: warning: u
nused variable 'flags'
make[6]: *** [nsNotifyAddrListener.o] Error 1
make[6]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/netwerk/sys
tem/win32'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/netwerk/sys
tem'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw/netwerk'
make[3]: *** [libs_tier_necko] Error 2
make[3]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make[2]: *** [tier_necko] Error 2
make[2]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/d/mozilla/mozilla/object-mingw'
make: *** [alldep] Error 2

Comment 10

[Martijn Wargers (dead)]

Attachment: adding loopback

Yeah, I get that too, after I have run autoconf (thanks for that tip, Chris).
This solves it for me, but I'm not sure if this is correct. Maybe this is something that should be fixed in mingw?

Comment 11

[cls]

Attachment: require w32api 3.8

You'll need to upgrade to w32api 3.8.

Comment 12

[cls]

Checking in configure;
/cvsroot/mozilla/configure,v  <--  configure
new revision: 1.1755; previous revision: 1.1754
done
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1746; previous revision: 1.1745
done