358033 - Undo transaction doesn't remember focusNode part of the selection

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Martijn Wargers (dead)]

To reproduce:
- Put some text in a textarea
- Select some text text from right to left/bottom to top
- Pres delete
- Press ctrl-z
- Press the right or left arrow key

Actual result:
The caret appears at the right/bottom side of where the selection was.

Expected result:
The caret should appear at the left/top side of where the selection was.

Comment 1

[Cheng]

Any update on this regression? I'm seeing the issue again. Here's a test case to reproduce:

https://codepen.io/cheng-lee/pen/yqywXa

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 358033 - Part 2. Add test. r?

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 358033 - Part 1. Restore direction of Selection. r?masayuki

SelectionState doesn't save and restore current selection's direction.  So the
direction of selection is always default after undoing.

So we should restore direction of selection.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 358033 - Part 2. Add test. r?masayuki

Comment 5

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9acad815a63bd9b1d07d79ee567f1a41f013963a

Comment 6

[Phabricator Automation]

Comment on attachment 8993578 [details]
Bug 358033 - Part 1. Restore direction of Selection. r?masayuki

Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision.

https://phabricator.services.mozilla.com/D2259

Comment 7

[Phabricator Automation]

Comment on attachment 8993588 [details]
Bug 358033 - Part 2. Add test. r?masayuki

Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision.

https://phabricator.services.mozilla.com/D2260

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69f61d0f8f81
Part 1. Restore direction of Selection. r=masayuki

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bc82dd8d837
Part 2. Add test. r=masayuki

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/69f61d0f8f81
https://hg.mozilla.org/mozilla-central/rev/0bc82dd8d837