358110 - Mac: Sunbird should be registered for ICS files and webcal[s] URLs

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Matthew (lilmatt) Willis]

Sunbird should be registered for ICS files and webcal[s] URLs on the Mac.
Most of this is done in Info.plist
We need some pretty icons too though.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: screenshots of the new ICS document icons

Comment 2

[Matthew (lilmatt) Willis]

Attachment: Registers Sunbird for ICS files and webcal URLs (using the nice icon for ICS)

Comment 3

[cmtalbert]

Comment on attachment 243549 [details]
screenshots of the new ICS document icons

Icons are pretty. r+

Comment 4

[cmtalbert]

(In reply to comment #3)
> (From update of attachment 243549 [details] [edit])
> Icons are pretty. r+
> 
Of course the one on the left claims to be a photoshop file, but I'm sure it will be an icns when you check it in.

Comment 5

[cmtalbert]

Comment on attachment 243550 [details] [diff] [review]
Registers Sunbird for ICS files and webcal URLs (using the nice icon for ICS)

This looks good. I just eyeballed it, and I don't see any issues with it.
However, I have one question:
Is this sufficient to handle the case where iCAL.app is already associated with ICS files?

Comment 6

[Matthew (lilmatt) Willis]

(In reply to comment #5)
> Is this sufficient to handle the case where iCAL.app is already associated with
> ICS files?

If you select an .ICS file in Finder.app and click "Get Info" from the gear icon (or hit Cmd-I) you can change the app it opens in, and then click "Change All" to change the default handler for .ICS files.

So, yes.

Comment 7

[Joey Minta]

Comment on attachment 243549 [details]
screenshots of the new ICS document icons

I'd say this just needs UI review, but r2=jminta if you want it.

Comment 8

[Joey Minta]

Comment on attachment 243550 [details] [diff] [review]
Registers Sunbird for ICS files and webcal URLs (using the nice icon for ICS)

I'd like to know why this isn't getting handled by our existing commandline handlers.  Are they detecting it at all?

Comment 9

[Matthew (lilmatt) Willis]

(In reply to comment #8)
As far as I can tell, no.  Do our command line handlers want file:/// style URLs?  I'm pretty sure that's not what they're getting from LaunchServices.

Comment 10

[Matthew (lilmatt) Willis]

(In reply to comment #9)
I stand corrected.

This is what "Open with..." > "Sunbird" on an .ICS file opens Sunbird with:

/Applications/CalendarDebug.app/Contents/MacOS/sunbird-bin -url file://localhost/Users/mwillis/Desktop/andrew2.ics -foreground

Comment 11

[Matthew (lilmatt) Willis]

Attachment: Same as previous, but handles -url command line switch as well.

Comment 12

[Joey Minta]

Comment on attachment 253898 [details] [diff] [review]
Same as previous, but handles -url command line switch as well.

I'm against pre-processing unless absolutely necessary.  Why not just allow -url and -subscribe to both be supported on all platforms?

You need to document the -url option for -help.

Does this work if Sunbird is already running?  I have a bad feeling I screwed that up when I messed around with the commandline handlers last time.

Comment 13

[Joey Minta]

Comment on attachment 243550 [details] [diff] [review]
Registers Sunbird for ICS files and webcal URLs (using the nice icon for ICS)

I'm assuming this has become obsolete due to the more recent patch?

Comment 14

[Matthew (lilmatt) Willis]

Comment on attachment 243550 [details] [diff] [review]
Registers Sunbird for ICS files and webcal URLs (using the nice icon for ICS)

ya. obsoleting it

Comment 15

[Matthew (lilmatt) Willis]

(In reply to comment #12)
> (From update of attachment 253898 [details] [diff] [review])
> I'm against pre-processing unless absolutely necessary.  Why not just allow
> -url and -subscribe to both be supported on all platforms?
It seemed silly to do so since it's only necessary for Mac OS X.

> You need to document the -url option for -help.
Neither Fx nor Tb do so. Do you still want me to? See below.

MacBook-2:~ mwillis$ /Applications/Firefox.app/Contents/MacOS/firefox-bin -help
Usage: /Applications/Firefox.app/Contents/MacOS/firefox-bin [ options ... ] [URL]
       where options include:

        --g-fatal-warnings              Make all warnings fatal

Mozilla options
        -height <value>         Set height of startup window to <value>.
        -h or -help             Print this message.
        -width <value>          Set width of startup window to <value>.
        -v or -version          Print Firefox version.
        -P <profile>            Start with <profile>.
        -ProfileManager         Start with Profile Manager.
        -UILocale <locale>              Start with <locale> resources as UI Locale.
        -contentLocale <locale>         Start with <locale> resources as content Locale.
        -safe-mode              Disables extensions and themes for this session.
  -jsconsole           Open the Error console.
  -browser            Open a browser window.
Usage: firefox [-flags] [<url>]
MacBook-2:~ mwillis$ /Applications/Thunderbird.app/Contents/MacOS/thunderbird-bin -help
Usage: /Applications/Thunderbird.app/Contents/MacOS/thunderbird-bin [ options ... ] [URL]
       where options include:

        --g-fatal-warnings              Make all warnings fatal

Mozilla options
        -height <value>         Set height of startup window to <value>.
        -h or -help             Print this message.
        -width <value>          Set width of startup window to <value>.
        -v or -version          Print Thunderbird version.
        -P <profile>            Start with <profile>.
        -ProfileManager         Start with Profile Manager.
        -UILocale <locale>              Start with <locale> resources as UI Locale.
        -contentLocale <locale>         Start with <locale> resources as content Locale.
        -safe-mode              Disables extensions and themes for this session.
  -jsconsole           Open the Error console.
  -addressbook         Open the address book at startup.
  -compose             Compose a mail or news message.
  -mail                Open the mail folder view.
  -options             Open the options dialog.
  -news                Open the news client.


> Does this work if Sunbird is already running?  I have a bad feeling I screwed
> that up when I messed around with the commandline handlers last time.

No. It brings Sb to the foreground, but nothing happens.

That said, this patch as it stands is an improvement from the current situation.

Comment 16

[Joey Minta]

(In reply to comment #15)
> It seemed silly to do so since it's only necessary for Mac OS X.
It doesn't hurt, and I really am anti-preprocessing

> 
> > You need to document the -url option for -help.
> Neither Fx nor Tb do so. Do you still want me to? See below.
Yeah, we can do better than them here.

> No. It brings Sb to the foreground, but nothing happens.
> 
The solution to this would be (I think) to do the calendar add in the actual commandline handler file.  I'd prefer to do this now, rather than committing code we know we're just going to delete/re-add in a second patch.

Comment 17

[Matthew (lilmatt) Willis]

Attachment: rev3 - Address most of jminta's comments

This removes the preprocessing, and adds the help text.

Regarding the last issue: 
We currently don't handle subscribing to a calendar when we're already running on _any_ platform.  Handling incoming command lines while running is a larger issue for the entire app.  I don't want to prevent this bug from landing in 0.5 while we build in that support.

Requesting review from mvl since ctalbert's on vaca and jminta's busy getting his law on.

Comment 18

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 258287 [details] [diff] [review]
rev3 - Address most of jminta's comments

r=mvl

Comment 19

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED