Closed Bug 358120 Opened 19 years ago Closed 19 years ago

add id attributes to passwordManager.xul

Categories

(Toolkit :: Password Manager, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: miken32, Assigned: martijn.martijn)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0 Adding a new button to the password manager dialog is impossible; the hbox containing the buttons has no id Reproducible: Always
Attached patch patch (obsolete) — Splinter Review
So you want something like this, I guess?
Attachment #243634 - Flags: review?(gavin.sharp)
Comment on attachment 243634 [details] [diff] [review] patch I'd use "SignonViewerButtons" to be consistent with the other IDs in this file. r=me with that.
Attachment #243634 - Flags: review?(gavin.sharp) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Ok, used SignonViewerButtons now.
Attachment #243634 - Attachment is obsolete: true
Checking in toolkit/components/passwordmgr/resources/content/passwordManager.xul ; /cvsroot/mozilla/toolkit/components/passwordmgr/resources/content/passwordManage r.xul,v <-- passwordManager.xul new revision: 1.12; previous revision: 1.11 done
Assignee: nobody → martijn.martijn
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: