Closed
Bug 358285
Opened 18 years ago
Closed 18 years ago
You can open multiple Password Manager windows at once
Categories
(Toolkit :: Preferences, defect)
Toolkit
Preferences
Tracking
()
VERIFIED
FIXED
People
(Reporter: mattwillis, Assigned: mattwillis)
Details
(Keywords: regression, verified1.8.1.1)
Attachments
(1 file)
|
1.29 KB,
patch
|
Gavin
:
first-review+
dveditz
:
approval1.8.1.1+
|
Details | Diff | Splinter Review |
Due to a typo in gavin's checking for bug 324063, passwordmanager.xul's windowtype changed from "Toolkit:PasswordManager" to "Toolkit:PasswordManagerExceptions". (Note that the additional passwordmanagerexceptions.xul checked in on that bug ALSO uses this windowtype) passwordmanager.xul's should be changed back to Toolkit:PasswordManager to fix the multiple open password manager windows bug.
|
Assignee | |
Comment 1•18 years ago
|
||
This reverts the two errors from this checkin: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/toolkit/components/passwordmgr/resources/content&command=DIFF_FRAMESET&file=passwordManager.xul&rev2=1.11&rev1=1.10 Check to make sure no one's looking for that id: http://lxr.mozilla.org/mozilla/search?string=SignonViewerExceptionDialog
Attachment #243733 -
Flags: second-review?(mconnor)
Attachment #243733 -
Flags: first-review?
Attachment #243733 -
Flags: approval1.8.1?
Attachment #243733 -
Flags: approval1.8.1.1?
|
|
Assignee | |
Updated•18 years ago
|
Attachment #243733 -
Flags: first-review? → first-review?(gavin.sharp)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 243733 [details] [diff] [review] removes erroneous "Exception[s]" from xul Hrm, that sucks. I guess this was a copy/paste error.
Attachment #243733 -
Flags: first-review?(gavin.sharp)
Attachment #243733 -
Flags: first-review+
Attachment #243733 -
Flags: approval1.8.1?
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [patch in hand][needs review mconnor]
|
|
||
Comment 3•18 years ago
|
||
I don't think this requires second-review, and mconnor's on vacation so shouldn't be reviewing anyways :) You should just land it on the trunk now.
|
|
Assignee | |
Comment 4•18 years ago
|
||
Comment on attachment 243733 [details] [diff] [review] removes erroneous "Exception[s]" from xul Goodness knows we wouldn't want mconnor to work on his vacation. :) Landed on trunk.
Attachment #243733 -
Flags: second-review?(mconnor)
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [patch in hand][needs review mconnor] → [patch in hand][needs a1811]
|
||
Comment 5•18 years ago
|
||
Comment on attachment 243733 [details] [diff] [review] removes erroneous "Exception[s]" from xul approved for 1.8 branch, a=dveditz for drivers
Attachment #243733 -
Flags: approval1.8.1.1? → approval1.8.1.1+
|
|
Assignee | |
Comment 6•18 years ago
|
||
Patch checked in on MOZILLA_1_8_BRANCH. -> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs a1811]
|
||
Comment 7•18 years ago
|
||
Verified that only one Password Manager window can be open at a time using: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1pre) Gecko/20061130 BonEcho/2.0.0.1pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.1 → verified1.8.1.1
You need to log in
before you can comment on or make changes to this bug.
Description
•