Closed Bug 358285 Opened 13 years ago Closed 13 years ago

You can open multiple Password Manager windows at once

Categories

(Toolkit :: Preferences, defect)

defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: mattwillis, Assigned: mattwillis)

Details

(Keywords: regression, verified1.8.1.1)

Attachments

(1 file)

Due to a typo in gavin's checking for bug 324063, passwordmanager.xul's windowtype changed from "Toolkit:PasswordManager" to "Toolkit:PasswordManagerExceptions". 

(Note that the additional passwordmanagerexceptions.xul checked in on that bug ALSO uses this windowtype)

passwordmanager.xul's should be changed back to Toolkit:PasswordManager to fix the multiple open password manager windows bug.
Attachment #243733 - Flags: first-review? → first-review?(gavin.sharp)
Comment on attachment 243733 [details] [diff] [review]
removes erroneous "Exception[s]" from xul

Hrm, that sucks. I guess this was a copy/paste error.
Attachment #243733 - Flags: first-review?(gavin.sharp)
Attachment #243733 - Flags: first-review+
Attachment #243733 - Flags: approval1.8.1?
Whiteboard: [patch in hand][needs review mconnor]
I don't think this requires second-review, and mconnor's on vacation so shouldn't be reviewing anyways :) You should just land it on the trunk now.
Comment on attachment 243733 [details] [diff] [review]
removes erroneous "Exception[s]" from xul

Goodness knows we wouldn't want mconnor to work on his vacation. :)

Landed on trunk.
Attachment #243733 - Flags: second-review?(mconnor)
Whiteboard: [patch in hand][needs review mconnor] → [patch in hand][needs a1811]
Comment on attachment 243733 [details] [diff] [review]
removes erroneous "Exception[s]" from xul

approved for 1.8 branch, a=dveditz for drivers
Attachment #243733 - Flags: approval1.8.1.1? → approval1.8.1.1+
Patch checked in on MOZILLA_1_8_BRANCH.

-> FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs a1811]
Verified that only one Password Manager window can be open at a time using: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1pre) Gecko/20061130
BonEcho/2.0.0.1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.