Closed Bug 358285 Opened 13 years ago Closed 13 years ago
You can open multiple Password Manager windows at once
Due to a typo in gavin's checking for bug 324063, passwordmanager.xul's windowtype changed from "Toolkit:PasswordManager" to "Toolkit:PasswordManagerExceptions". (Note that the additional passwordmanagerexceptions.xul checked in on that bug ALSO uses this windowtype) passwordmanager.xul's should be changed back to Toolkit:PasswordManager to fix the multiple open password manager windows bug.
This reverts the two errors from this checkin: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/toolkit/components/passwordmgr/resources/content&command=DIFF_FRAMESET&file=passwordManager.xul&rev2=1.11&rev1=1.10 Check to make sure no one's looking for that id: http://lxr.mozilla.org/mozilla/search?string=SignonViewerExceptionDialog
Attachment #243733 - Flags: first-review? → first-review?(gavin.sharp)
Comment on attachment 243733 [details] [diff] [review] removes erroneous "Exception[s]" from xul Hrm, that sucks. I guess this was a copy/paste error.
Whiteboard: [patch in hand][needs review mconnor]
I don't think this requires second-review, and mconnor's on vacation so shouldn't be reviewing anyways :) You should just land it on the trunk now.
Comment on attachment 243733 [details] [diff] [review] removes erroneous "Exception[s]" from xul Goodness knows we wouldn't want mconnor to work on his vacation. :) Landed on trunk.
Whiteboard: [patch in hand][needs review mconnor] → [patch in hand][needs a1811]
Comment on attachment 243733 [details] [diff] [review] removes erroneous "Exception[s]" from xul approved for 1.8 branch, a=dveditz for drivers
Attachment #243733 - Flags: approval188.8.131.52? → approval184.108.40.206+
Patch checked in on MOZILLA_1_8_BRANCH. -> FIXED
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [patch in hand][needs a1811]
Verified that only one Password Manager window can be open at a time using: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:220.127.116.11pre) Gecko/20061130 BonEcho/18.104.22.168pre
You need to log in before you can comment on or make changes to this bug.