User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.1) Gecko/20061009 Firefox/2.0 Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.1) Gecko/20061009 Firefox/2.0 Crash when closing choose download folder dialog using top right menu. Reproducible: Always
Yep, I see this, too. I tried to find out where it happens and the POPUPLOG.OS2 address of one of my Firefox 2 builds points to nsFilePicker::Show(). Have to wait for a debug build to analyze the problem with a debugger.
Created attachment 248190 [details] [diff] [review] add NULL check Somehow the ^ marker in the string is gone when the dialog is dismissed using the system menu. This extra NULL check avoids the crash and doesn't do any harm because the string is only used in the case of DID_OK. This is such an obvious fix that I think I should check into trunk and branch at the same time...
Comment on attachment 248190 [details] [diff] [review] add NULL check r=mkaply
Fix checked into trunk and 1.8 branch.
This was obviously checked in too late for 188.8.131.52 (and I confirmed that Firefox 184.108.40.206 still crashes).
Verified fixed on trunk using "Gecko/20061222 Minefield/3.0a2pre" nightly.
Hi peter, can you verify this fix for us on OS/2 in the 220.127.116.11 branch as well? We dont have OS/2 here installed, and hopefully it'll be a quick verification for you. When you are done, please change the keyword "fixed18.104.22.168" to "verified22.214.171.124" for tracking purposes. Thanks!
Verifying some older bugs. (As we don't have branch nightlies nor RCs of Firefox on OS/2, I can only verify now.)