Closed Bug 358392 Opened 18 years ago Closed 18 years ago

no hash checking on installTrigger call on front page

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: shaver, Assigned: cameron)

Details

Attachments

(1 file)

In the rusticoizing, I guess I dropped the hash parameter from the install button.

Must fix!

(Thanks to Jesse for the catch.)
Attached patch PatchSplinter Review
Here's our patch.

Don't worry Shaver, not your fault,, it seems that we never used the hash on the frontpage before either - whoops :)

Also included: 
Tooltip on install button which was missing.
"Install Now" instead of "Install Extension" when using Cavendish - in case we ever decide to recommend themes.
Assignee: nobody → cameron
Status: NEW → ASSIGNED
Attachment #243806 - Flags: first-review?(shaver)
Comment on attachment 243806 [details] [diff] [review]
Patch

hot -- commit to staging?
Attachment #243806 - Flags: first-review?(shaver) → first-review+
This has been committed and tagged for staging.
Tagged for production.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: