no hash checking on installTrigger call on front page

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Public Pages
--
major
RESOLVED FIXED
11 years ago
2 years ago

People

(Reporter: shaver, Assigned: Cameron)

Tracking

Details

Attachments

(1 attachment)

In the rusticoizing, I guess I dropped the hash parameter from the install button.

Must fix!

(Thanks to Jesse for the catch.)
(Assignee)

Comment 1

11 years ago
Created attachment 243806 [details] [diff] [review]
Patch

Here's our patch.

Don't worry Shaver, not your fault,, it seems that we never used the hash on the frontpage before either - whoops :)

Also included: 
Tooltip on install button which was missing.
"Install Now" instead of "Install Extension" when using Cavendish - in case we ever decide to recommend themes.
Assignee: nobody → cameron
Status: NEW → ASSIGNED
Attachment #243806 - Flags: first-review?(shaver)
Comment on attachment 243806 [details] [diff] [review]
Patch

hot -- commit to staging?
Attachment #243806 - Flags: first-review?(shaver) → first-review+
(Assignee)

Comment 3

11 years ago
This has been committed and tagged for staging.
Tagged for production.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.