358451 - bottom of the tabbar no longer matches the color of the active tab

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061027 Minefield/3.0a1 ID:2006102716 [cairo]

Open FF and look at the narrow strip under the tabs
It has the wrong color

regressionwindow:
works in firefox-3.0a1.en-US.win32_20061026_1003pdt
fails in firefox-3.0a1.en-US.win32_20061026_1234pdt

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20061026+0930&maxdate=20061026+1234&cvsroot=%2Fcvsroot

possibly Bug 357761

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: testcase

This is a testcase.  The first div is drawn with an identical style as that particular box is drawn in the tabbar.  It has both a solid color (-moz-dialog) and a 1x1 repeating PNG, which is semi-transparent.  The second div is only -moz-dialog, and the third div is only the png image (repeated).

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: image comparing 1.8 and 1.9

Two problems here -- in 1.8, the single-pixel png image seems to have no effect on the resulting color.  In 1.9, the png image is rendered wrong, due to the single-pixel optimization not un-pre-multiplying the alpha correctly.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: unpremultiply single-pixel alpha

Marking stuart's r+

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Fix checked in.