358454 - Tinderbox cron job sending mail about failed mails on every run

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Dave Miller [:justdave]]

I'm getting mail once a minute (the frequency of the cron job) from the new tinderbox install with the following in it:

-----8<-----
Variable 'tinderbox:status' must be 'success', 'busted', 'testfailed', or 'building'
Variable 'tinderbox:status' must be 'success', 'busted', 'testfailed', or 'building'
Variable 'tinderbox:status' must be 'success', 'busted', 'testfailed', or 'building'
-----8<-----

I'm assuming this means there's three mails in the queue which are invalid.  But it's neither removing them from the queue nor giving me a queue filename so I know which one to remove (and there's typically many more than 3 in there anytime I look).

Comment 1

[cls]

Attachment: v1.0

I wasn't sure what to do with this.  When the mail was still being processed via sendmail, we just dropped any mails that had issues.  Now, we can store them for inspection but I don't know if it's worth it.  Especially for a high volume site.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 244602 [details] [diff] [review]
v1.0

I like this plan.  Then we can go periodically toss them and I just get one notice that it's tossed one.

Comment 3

[cls]

Checking in webtools/tinderbox/Makefile;
/cvsroot/mozilla/webtools/tinderbox/Makefile,v  <--  Makefile
new revision: 1.18; previous revision: 1.17
done
Checking in webtools/tinderbox/processbuild.pl;
/cvsroot/mozilla/webtools/tinderbox/processbuild.pl,v  <--  processbuild.pl
new revision: 1.60; previous revision: 1.59
done