Closed
Bug 358512
Opened 18 years ago
Closed 17 years ago
notification sliding does not complete last step
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
People
(Reporter: Mook, Assigned: Mook)
References
()
Details
Attachments
(1 file, 1 obsolete file)
1.47 KB,
patch
|
Mook
:
first-review+
|
Details | Diff | Splinter Review |
I'm seeing this in the Addons window notification (not doing compatibility checking). The <notificationbox>/<notification> sliding animation ends up with the top cropped off, and very ugly. Steps to reproduce: 1. Set extensions.checkCompatibility to false in about:config 2. Tools -> Addons 3. Wait for the notification up top to stop Expected results: Top and bottom margins of the yellow bar should be approximately equal Actual results: Top margin is less. (About 7px in my case) Patch coming.
This was because the rounding isn't exact, so I ended up having something like -0.0000004px margins. That would be fine except the string concatenation made it end up being "-4.76837158203125e-7px" which confuses the style system. Using .toFixed() prevents the silly exponential from showing up. I doubt anyone cares about ten thousandths of a pixel... :p
Assignee: nobody → mook.moz+sites.org.mozilla.bugzilla
Status: NEW → ASSIGNED
Attachment #243898 -
Flags: first-review?(gavin.sharp)
Comment 2•18 years ago
|
||
This reminds me very much of the patch in bug 350157.
Comment 3•18 years ago
|
||
Please compare with the patch in bug 350157 and request review for the one you prefer there :) *** This bug has been marked as a duplicate of 350157 ***
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Updated•18 years ago
|
Attachment #243898 -
Flags: first-review?(gavin.sharp)
Comment on attachment 243898 [details] [diff] [review] Round off Oops, forgot about this - since Neil likes this patch better, please review it? :) (see bug 350157 comment 9) No changes to the file appear to have taken since it the patch was made, so it should still apply on trunk
Attachment #243898 -
Flags: first-review?(enndeakin)
Comment 5•18 years ago
|
||
Comment on attachment 243898 [details] [diff] [review] Round off I think only the second of these changes is necessary. In the first change, height will always be an integer.
Attachment #243898 -
Flags: first-review?(enndeakin) → first-review+
Thanks, didn't realize boxObject.height was always an integer. (It does seem to be the case, even though computed style gave a fractional height) Carrying forward r+, updating to current trunk. (CVS merged cleanly, btw) Will reopen and ask for checkin in a bit.
Attachment #243898 -
Attachment is obsolete: true
Attachment #247371 -
Flags: first-review+
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Whiteboard: [checkin needed]
Comment 7•18 years ago
|
||
mozilla/toolkit/content/widgets/notification.xml 1.12
Status: REOPENED → ASSIGNED
OS: Windows XP → All
Hardware: PC → All
Whiteboard: [checkin needed]
Comment 8•18 years ago
|
||
*** Bug 350157 has been marked as a duplicate of this bug. ***
Comment 9•17 years ago
|
||
This should be marked fixed right?
Assignee | ||
Comment 10•17 years ago
|
||
Err, yes, it should. Sorry.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•