R_386_PC32 relocations in libtracemalloc.so when building on FC6

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({fixed1.8.0.9, fixed1.8.1.1})

Trunk
x86
Linux
fixed1.8.0.9, fixed1.8.1.1
Points:
---
Bug Flags:
blocking1.9 ?
blocking1.8.1.1 -
blocking1.8.0.9 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
When building on Fedora Core 6 (where our system wrappers stuff works, and where the big gcc visibility bug is fixed), SELinux prevents me from starting due to the bad type of relocations in libtracemalloc.so and libxul.so.  This bug covers the problem in libtracemalloc.so.

The problem there is that we manually declare a bunch of __libc_* functions without going through the visibility-wrapping that we do for all other system headers.
(Assignee)

Comment 1

11 years ago
Created attachment 243932 [details] [diff] [review]
patch
Attachment #243932 - Flags: review?(benjamin)
(Assignee)

Updated

11 years ago
Flags: blocking1.9?
Flags: blocking1.8.1.1?
Flags: blocking1.8.0.9?

Updated

11 years ago
Attachment #243932 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

11 years ago
Checked in to trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

11 years ago
Comment on attachment 243932 [details] [diff] [review]
patch

This is a very low risk patch that will, along with the patches to bug 358559 and bug 358565:
 * make it easier for developers to build on new distributions like Fedora Core 6

It's also not part of code that we ship -- it's in a debugging tool.
Attachment #243932 - Flags: approval1.8.1.1?
Attachment #243932 - Flags: approval1.8.0.9?
(Assignee)

Updated

11 years ago
Blocks: 359275
Can't see how we can call this a "blocker", but looks like goodness.
Flags: blocking1.8.1.1?
Flags: blocking1.8.1.1-
Flags: blocking1.8.0.9?
Flags: blocking1.8.0.9-
Comment on attachment 243932 [details] [diff] [review]
patch

approved for 1.8/1.8.0 branches, a=dveditz for drivers
Attachment #243932 - Flags: approval1.8.1.1?
Attachment #243932 - Flags: approval1.8.1.1+
Attachment #243932 - Flags: approval1.8.0.9?
Attachment #243932 - Flags: approval1.8.0.9+
(Assignee)

Comment 6

11 years ago
Checked in to MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
Keywords: fixed1.8.0.9, fixed1.8.1.1
You need to log in before you can comment on or make changes to this bug.