Closed Bug 358558 Opened 13 years ago Closed 13 years ago

R_386_PC32 relocations in libtracemalloc.so when building on FC6

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: fixed1.8.0.9, fixed1.8.1.1)

Attachments

(1 file)

When building on Fedora Core 6 (where our system wrappers stuff works, and where the big gcc visibility bug is fixed), SELinux prevents me from starting due to the bad type of relocations in libtracemalloc.so and libxul.so.  This bug covers the problem in libtracemalloc.so.

The problem there is that we manually declare a bunch of __libc_* functions without going through the visibility-wrapping that we do for all other system headers.
Attached patch patchSplinter Review
Attachment #243932 - Flags: review?(benjamin)
Flags: blocking1.9?
Flags: blocking1.8.1.1?
Flags: blocking1.8.0.9?
Attachment #243932 - Flags: review?(benjamin) → review+
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 243932 [details] [diff] [review]
patch

This is a very low risk patch that will, along with the patches to bug 358559 and bug 358565:
 * make it easier for developers to build on new distributions like Fedora Core 6

It's also not part of code that we ship -- it's in a debugging tool.
Attachment #243932 - Flags: approval1.8.1.1?
Attachment #243932 - Flags: approval1.8.0.9?
Can't see how we can call this a "blocker", but looks like goodness.
Flags: blocking1.8.1.1?
Flags: blocking1.8.1.1-
Flags: blocking1.8.0.9?
Flags: blocking1.8.0.9-
Comment on attachment 243932 [details] [diff] [review]
patch

approved for 1.8/1.8.0 branches, a=dveditz for drivers
Attachment #243932 - Flags: approval1.8.1.1?
Attachment #243932 - Flags: approval1.8.1.1+
Attachment #243932 - Flags: approval1.8.0.9?
Attachment #243932 - Flags: approval1.8.0.9+
Checked in to MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH.
You need to log in before you can comment on or make changes to this bug.