358568 - Calendar webpages fail HTML 4.01 strict validation

Status: RESOLVED FIXED

(Calendar :: Website, defect)

Description

[Gérard Talbot]

The webpages

Calendar FAQ
http://www.mozilla.org/projects/calendar/faq.html (72 errors)

Sunbird download
http://www.mozilla.org/projects/calendar/sunbird/l10n_download.html (9 errors)

Calendar project page
http://www.mozilla.org/projects/calendar/ (5 errors)

Calendar links
http://www.mozilla.org/projects/calendar/links.html (1 error)

There might be other webpages failing validation.

CC: Simon Paquet

If you allow me to fix this bug, I would add a [crumb]breads intra-site navigation: see 
http://www.mozilla.org/contribute/writing/markup#navigation
and 
http://www.mozilla.org/projects/minimo/FAQ.html
for how it looks. 

I would also style external links with class="ex-ref"
(see http://www.mozilla.org/contribute/writing/markup#navigation)

Simon, if you prefer to take this bug, all is fine with me. If you prefer that I fix the errors, it's also fine with me. Either way is fine with me.

Comment 1

[Gérard Talbot]

Also

Lightning 0.3 Release Notes (2 errors)
http://www.mozilla.org/projects/calendar/releases/lightning0.3.html
line 167 column 47 - Error: end tag for "A" omitted, but its declaration does not permit this
line 251 column 14 - Error: ID "NAV" already defined


Sunbird 0.3 Release Notes
http://www.mozilla.org/projects/calendar/releases/sunbird0.3.html
line 388 column 14 - Error: ID "NAV" already defined

Comment 2

[Simon Paquet [:sipaq]]

Thanks for the information.

I fixed 

- http://www.mozilla.org/projects/calendar/faq.html
- http://www.mozilla.org/projects/calendar/links.html
- http://www.mozilla.org/projects/calendar/releases/lightning0.3.html
- http://www.mozilla.org/projects/calendar/releases/sunbird0.3.html

Fixing

- http://www.mozilla.org/projects/calendar/sunbird/l10n_download.html
- http://www.mozilla.org/projects/calendar/

is not so easy. The first page seems to be alright as far as I can see, it probably can't be parsed correctly by the SGML parser, because of the JS generated HTML.

Fixing the 2nd page would result in a broken layout, because the #product-desc and #product-side rules on the site stylesheet http://www.mozilla.org/css/cavendish/content.css probably only expected one product to be advertised on a page. 

Therefore we'll probably have to live with this, since I really don't want to duplicate all this stuff on the sub-stylesheet calendar.css, because that will only result in trouble, should MoFo/MoCo decide, that a new design would be a good idea.

Regarding your other ideas. I would really like to see a new bug for this, with a patch and a short mockup, if possible.

Comment 3

[Gérard Talbot]

> Fixing
> - http://www.mozilla.org/projects/calendar/sunbird/l10n_download.html
> is not so easy. The first page seems to be alright as far as I can see, it
> probably can't be parsed correctly by the SGML parser, because of the JS
> generated HTML.


You need to escape the / inside the <script>-ed HTML. This is easy to fix :)

Common Validation Problems and how to fix them
Writing HTML in a SCRIPT Element
http://www.htmlhelp.com/tools/validator/problems.html.en#script

Examples given:

at line 125:

document.writeln("<td class='dl'><a href=\"" + getDownloadURLForLanguage(build, PLATFORM_LINUX) + "\">Download</a></td></tr>");

becomes

document.writeln("<td class='dl'><a href=\"" + getDownloadURLForLanguage(build, PLATFORM_LINUX) + "\">Download<\/a><\/td><\/tr>");

and at line 133

document.writeln("</table>");

becomes

document.writeln("<\/table>");

-----------

I recommend using HTML Validator 0.8.3.3 (or higher)
http://users.skynet.be/mgueury/mozilla/preview_080.html
since such extension is embedded into Firefox 2, one can immediately see how many validation problems or things that Tidy can fix. In SGML parser mode, it works just like the W3C validator.

E.g.: unescaped & and empty <p></p> will be reported by Tidy which SGML parser won't report.
http://www.mozilla.org/projects/calendar/faq.html has 7 empty <p></p> and 2 unescaped &

------------

> I really don't want to duplicate all this stuff on the 
> sub-stylesheet calendar.css

I understand. Ideally, best would be to use and only use the already written stylesheets like /css/cavendish/content.css


------------

Regarding breadcrumbs intra-site navigation, I'll create a bug for this.

Comment 4

[Simon Paquet [:sipaq]]

(In reply to comment #3)
>> Fixing
>> - http://www.mozilla.org/projects/calendar/sunbird/l10n_download.html
>> is not so easy. The first page seems to be alright as far as I can see, it
>> probably can't be parsed correctly by the SGML parser, because of the JS
>> generated HTML.
> 
> You need to escape the / inside the <script>-ed HTML. This is easy to fix :)

If you could provide a patch I'll gladly take it. Thanks.

Comment 5

[Gérard Talbot]

Attachment: Proposed patch for escaping forward slashes in <script>-ed HTML

I hope this is ok... not 100% sure how to submit patches actually ... I copied the "Show Diff" in Doctor interface.

Comment 6

[Gérard Talbot]

> empty <p></p> will be reported by Tidy 
> http://www.mozilla.org/projects/calendar/faq.html has 7 empty <p></p>

This is also within the 
mozilla.org Documentation Style Guide
http://www.mozilla.org/contribute/writing/guidelines#markup
which states
"Use <p> to enclose  paragraphs, not <br> or <p> to separate them"

Comment 7

[Reed Loden [:reed]]

(In reply to comment #5)
> I hope this is ok... not 100% sure how to submit patches actually ... I copied
> the "Show Diff" in Doctor interface.

To download a patch that you can attach to Doctor, go to the "Save Changes" tab and click the "Download Diff" button.

Comment 8

[Gérard Talbot]

> Regarding breadcrumbs intra-site navigation, I'll create a bug for this.

See bug 358642 for that particular issue

Comment 9

[Simon Paquet [:sipaq]]

Ok, I fixed the two outstanding issues (paragraph style on faq.html and the escaping issue on l10n_download.html). Marking FIXED again.