358628 - Themes without preview image are not auto-denied

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Florian Schmitz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0

If you upload a new theme and forget to upload a preview image, the theme is not automatically denied. The problem is that you have to wait (at least) two times until your theme is approved.

Reproducible: Always

Steps to Reproduce:
See desc.

Actual Results:  
Theme has to be denied manually.

Expected Results:  
Theme is denied automatically. Or status of the theme is not "awaiting approval" but rather "waiting for preview image upload".

Comment 1

[Justin Scott [:fligtar]]

We cannot auto-deny or require the previews because previews cannot be uploaded until the add-on is created, but other possibilities include:
- a new status of awaiting preview upload, as you stated
- a strong suggestion upon finishing submission
- an email upon submission stating that it's waiting on that
- making preview upload part of the additem process for themes (and optional for other add-on types)

Comment 2

[Justin Scott [:fligtar]]

In Remora, the nomination page strongly suggests that add-ons should have previews, but I do plan to make it required for themes.

Comment 3

[Cameron]

Preview images are currently required for themes by "policy" ...

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I think we should require preview images for anything that's coming out of the sandbox.  If Foxmarks can have them, I think anything can, really.

Comment 5

[Justin Scott [:fligtar]]

I'd like to require a preview image for themes AND extensions to be nominated for public. Language packs, dictionaries, and search engines would not require a preview.

Any objections?

Comment 6

[Fred Wenzel [:wenzel]]

(In reply to comment #5)
> I'd like to require a preview image for themes AND extensions to be nominated
> for public.

I think it's a good idea: A preview image should be part of a good add-on description, and without a good description an add-on is not ready to go public.

Comment 7

[Basil Hashem [:baz]]

No objections from me. I think what comment 5 has is a good policy.

Comment 8

[Justin Scott [:fligtar]]

This is now fixed in 3.5. In order to nominate your theme or extension, you must have a preview.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of what's needed to nominate

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://remora-3.5.php5stage.mozilla.com/en-US/developers/addon/status/7528/complete