358647 - nsIAbDirectory.supportsMailingLists is inconsistent.

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

nsIAbDirectory.supportsMailingLists is inconsistent - highlighted by work in progress on bug 358333.

For instance getting a directory with the uri:

moz-abldapdirectory://ldap_2.servers.pudsey

supports returns false, isMailList returns false - both as expected. With uri:

moz-abmdbdirectory://impab-10.mab

supports returns true, isMailList returns false - again as expected. With uri:

moz-abmdbdirectory://impab-8.mab/MailList1

supports returns true, isMailList returns true. At first glance this is sort of expected, because a moz-abmdbdirectory supports mailing lists. However, it could be taken to imply that we support nested mailing lists - which we don't. Therefore, I think this should actually be supports returns false, isMailList returns true.

Comment 1

[Mark Banner (:standard8)]

Attachment: Patch v1

nsIAbDirectory.supportsMailingLists will return true if its not a mailing list. I've also added more documentation to the idl to make this clearer - note that I've not updated the uuid as its a doc-only change, so I don't think its required.

I don't think this will affect http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#4192 - it'll just mean we don't search mailing lists, but as the card is meant to be in the parent anyway, that shouldn't matter.

LDAP doesn't support mailing lists and overrides the function.

David, does our Outlook interface support nested mailing lists and should we be overriding it to let us do so?

Comment 2

[David :Bienvenu]

Comment on attachment 244004 [details] [diff] [review]
Patch v1

nice, thx.

Comment 3

[Mark Banner (:standard8)]

Patch checked into trunk -> Fixed.