358695 - Week(Multiday)view: vertical time column too wide, should be narrower

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061029 Calendar/0.4a1

In Week view, the left column listing the hours is too wide.
It could be much narrower, to leave more horizontal space for text of events.



Reproducible: Always

Steps to Reproduce:
1. View Week view

Actual Results:  
Leftmost column with times looks almost twice as wide as necessary.



Expected Results:  
Leftmost column width just wide enough to hold longest standard format, 
"11:00 AM".

Note: left column width is set by the theme (not by laying out column contents) so that column width inside scrolling region lines up with column width outside scrolling region.

Note: left column width must be wide enough to accommodate user's OS setting for time format.  A possible AM/PM time such as "11:00 AM" is wider than 24 hour time such as "23:00", so a fixed theme width must be wide enough for the former.

Comment 1

[gekacheka]

Attachment: Patch: narrow timebar in its vertical orientation

(patch -l -p 2 -i file.patch)

  * narrows time bar width from 100 to 60px.
  * narrows time bar label margin to 2px, overriding default.
  * moves text-align: right so it works, needed for columns of times
     9:00 AM
    10:00 AM

Depends on bug 358688 to move widths to CSS.
Depends on bug 358692 so transpose button is small icon, not wide text.

Comment 2

[gekacheka]

Attachment: Image showing narrow time column at left.

Comment 3

[gekacheka]

Comment on attachment 244058 [details] [diff] [review]
Patch: narrow timebar in its vertical orientation

mvl, do you agree that narrowing the vertical time column, leaving more space for events in the hour grid, improves the week view UI?

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 244058 [details] [diff] [review]
Patch: narrow timebar in its vertical orientation

ui-review=mvl on wasting less space.

Comment 5

[klint]

This is true as well for the Day-view.
This issue becomes more important now that the Today-pane is also displayed in Calendar mode, hence reducing the available space for the calendar itself to be displayed... so, every unused inch should be employed!
Thanks

Comment 6

[gekacheka]

Attachment: Patch v2: narrow timebar in its vertical orientation

(patch -l -p 1 -i file.patch)

Refresh patch.
Made width 10ex rather than 60px so it scales with font.
(tested on w2k: Control Panel / Display / Appearance / Message Text
 set size to 16, click 'Apply'.)

Comment 7

[Martin Schröder [:mschroeder]]

Do we need ui-review for the patch?

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 327297 [details] [diff] [review]
Patch v2: narrow timebar in its vertical orientation

> calendar-time-bar[anonid="timebar"][orient="vertical"] {
>-  width: 100px;
>+  width: 10ex; /* space for "11:00 AM" */
Why not 10em? Are numbers generally about the size of an X ?


r=philipp

Comment 9

[gekacheka]

(In reply to comment #8)
> (From update of attachment 327297 [details] [diff] [review])
> > calendar-time-bar[anonid="timebar"][orient="vertical"] {
> >-  width: 100px;
> >+  width: 10ex; /* space for "11:00 AM" */
> Why not 10em? Are numbers generally about the size of an X ?

yes.  a lowercase x is usually square and the width of a digit is usually more proportional to that than to the height of the font.  (An ex is the height of a lowercase 'x'.  I think an em was originally the width of a square uppercase 'M' (as in em-dash) though CSS defines it as the height of the font.  http://www.w3.org/TR/CSS21/syndata.html#length-units) 

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 11

[Andreas Treumann]

Checked in lightning 2008070703 and sunbird 20080706 -> VERIFIED