358710 - Some UI stylecode should be moved from /content/xpinstallConfirm.css to /skin/

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Alfred Kayser]

In mozilla/ toolkit/ mozapps/ xpinstall/ content/ xpinstallConfirm.css (1.2):
the following lines:
 6 ben   1.2 .listbox {
 7             -moz-appearance: listbox;
 8           }
 9           
10           #itemList {
11             margin: 10px 4px 10px 4px;
12           }

should be moved to: 
/toolkit/themes/winstripe/mozapps/xpinstall/xpinstallConfirm.css
/toolkit/themes/pinstripe/mozapps/xpinstall/xpinstallConfirm.css

This is needed to allow themes to apply their own styling to this window, without having to override these forcefully with '!important'.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

pinstripe and winstripe already have these set... I moved the one for winstripe for consistency with pinstripe. The before and after display of this dialog are the same.

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/xpinstall/xpinstallConfirm.css#1

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 271496 [details] [diff] [review]
patch

r=sspitzer

Comment 3

[Robert Strong (they/them - no direct email)]

Checked in to trunk