bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Some UI stylecode should be moved from /content/xpinstallConfirm.css to /skin/

RESOLVED FIXED in mozilla1.9alpha8

Status

Toolkit Graveyard
XULRunner
--
minor
RESOLVED FIXED
12 years ago
2 years ago

People

(Reporter: Alfred Kayser, Assigned: rstrong)

Tracking

unspecified
mozilla1.9alpha8
Bug Flags:
in-testsuite -

Details

Attachments

(1 attachment)

1.60 KB, patch
(not reading, please use seth@sspitzer.org instead)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
In mozilla/ toolkit/ mozapps/ xpinstall/ content/ xpinstallConfirm.css (1.2):
the following lines:
 6 ben   1.2 .listbox {
 7             -moz-appearance: listbox;
 8           }
 9           
10           #itemList {
11             margin: 10px 4px 10px 4px;
12           }

should be moved to: 
/toolkit/themes/winstripe/mozapps/xpinstall/xpinstallConfirm.css
/toolkit/themes/pinstripe/mozapps/xpinstall/xpinstallConfirm.css

This is needed to allow themes to apply their own styling to this window, without having to override these forcefully with '!important'.
Created attachment 271496 [details] [diff] [review]
patch

pinstripe and winstripe already have these set... I moved the one for winstripe for consistency with pinstripe. The before and after display of this dialog are the same.

http://lxr.mozilla.org/seamonkey/source/toolkit/themes/pinstripe/mozapps/xpinstall/xpinstallConfirm.css#1
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #271496 - Flags: review?(sspitzer)
Comment on attachment 271496 [details] [diff] [review]
patch

r=sspitzer
Attachment #271496 - Flags: review?(sspitzer) → review+
Checked in to trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta1

Updated

11 years ago
Flags: in-testsuite-
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.