358795 - Duplicated accesskey in New Saved Search Folder dialog and unused strings

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061030 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061030 SeaMonkey/1.5a

The New Saved Search Folder dialog has a duplicated accesskey (O) for both "Search Online" and "Match any of the following". Moreover, the searchCriteria*.* strings are unused in the sources.
This affects also TB (at least for the unused strings). 

Reproducible: Always

Comment 1

[Giacomo Magnini]

Attachment: Obvious patch. I reformatted the SM dtd file (not sure if this is wanted for tb also), leaving the TB one only with the fix.

Comment 2

[David :Bienvenu]

Comment on attachment 244115 [details] [diff] [review]
Obvious patch. I reformatted the SM dtd file (not sure if this is wanted for tb also), leaving the TB one only with the fix.

probably want a SM person like Neil to look at the SM patch.

Comment 3

[[e-mail]]

Comment on attachment 244115 [details] [diff] [review]
Obvious patch. I reformatted the SM dtd file (not sure if this is wanted for tb also), leaving the TB one only with the fix.

>+<!ENTITY searchOnline.label            "Search Online (Gives up-to-date results for IMAP and News folders but increases time to open the folder)">
Note: This description reads a little tersely, perhaps it could be extended?

Comment 4

[Giacomo Magnini]

Neil, Karsten: can someone please check this in? TIA, Giacomo.
Probably TB people will want this for 2.0?

Comment 5

[Karsten Düsterloh]

Landed on trunk.