Duplicated accesskey in New Saved Search Folder dialog and unused strings

RESOLVED FIXED

Status

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: prometeo.bugs, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061030 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061030 SeaMonkey/1.5a

The New Saved Search Folder dialog has a duplicated accesskey (O) for both "Search Online" and "Match any of the following". Moreover, the searchCriteria*.* strings are unused in the sources.
This affects also TB (at least for the unused strings). 

Reproducible: Always
(Reporter)

Comment 1

12 years ago
Created attachment 244115 [details] [diff] [review]
Obvious patch. I reformatted the SM dtd file (not sure if this is wanted for tb also), leaving the TB one only with the fix.
Attachment #244115 - Flags: review?
(Reporter)

Updated

12 years ago
Attachment #244115 - Flags: review? → review?(bienvenu)

Comment 2

12 years ago
Comment on attachment 244115 [details] [diff] [review]
Obvious patch. I reformatted the SM dtd file (not sure if this is wanted for tb also), leaving the TB one only with the fix.

probably want a SM person like Neil to look at the SM patch.
Attachment #244115 - Flags: review?(bienvenu) → review+
(Reporter)

Updated

12 years ago
Attachment #244115 - Flags: superreview?(neil)
Comment on attachment 244115 [details] [diff] [review]
Obvious patch. I reformatted the SM dtd file (not sure if this is wanted for tb also), leaving the TB one only with the fix.

>+<!ENTITY searchOnline.label            "Search Online (Gives up-to-date results for IMAP and News folders but increases time to open the folder)">
Note: This description reads a little tersely, perhaps it could be extended?
Attachment #244115 - Flags: superreview?(neil) → superreview+
(Reporter)

Comment 4

12 years ago
Neil, Karsten: can someone please check this in? TIA, Giacomo.
Probably TB people will want this for 2.0?

Comment 5

12 years ago
Landed on trunk.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

11 years ago
Component: MailNews: Search → MailNews: Message Display
You need to log in before you can comment on or make changes to this bug.