Closed
Bug 358795
Opened 19 years ago
Closed 18 years ago
Duplicated accesskey in New Saved Search Folder dialog and unused strings
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: prometeo.bugs, Unassigned)
Details
Attachments
(1 file)
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061030 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061030 SeaMonkey/1.5a
The New Saved Search Folder dialog has a duplicated accesskey (O) for both "Search Online" and "Match any of the following". Moreover, the searchCriteria*.* strings are unused in the sources.
This affects also TB (at least for the unused strings).
Reproducible: Always
Reporter | ||
Comment 1•19 years ago
|
||
Attachment #244115 -
Flags: review?
Reporter | ||
Updated•19 years ago
|
Attachment #244115 -
Flags: review? → review?(bienvenu)
Comment 2•19 years ago
|
||
Comment on attachment 244115 [details] [diff] [review]
Obvious patch. I reformatted the SM dtd file (not sure if this is wanted for tb also), leaving the TB one only with the fix.
probably want a SM person like Neil to look at the SM patch.
Attachment #244115 -
Flags: review?(bienvenu) → review+
Reporter | ||
Updated•19 years ago
|
Attachment #244115 -
Flags: superreview?(neil)
Comment 3•19 years ago
|
||
Comment on attachment 244115 [details] [diff] [review]
Obvious patch. I reformatted the SM dtd file (not sure if this is wanted for tb also), leaving the TB one only with the fix.
>+<!ENTITY searchOnline.label "Search Online (Gives up-to-date results for IMAP and News folders but increases time to open the folder)">
Note: This description reads a little tersely, perhaps it could be extended?
Attachment #244115 -
Flags: superreview?(neil) → superreview+
Reporter | ||
Comment 4•18 years ago
|
||
Neil, Karsten: can someone please check this in? TIA, Giacomo.
Probably TB people will want this for 2.0?
Comment 5•18 years ago
|
||
Landed on trunk.
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•