358867 - Return value in a void function

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Alfred Peng]

There is a problem in the build process:
"jsapi.c", line 1805: void function cannot return value
cc: acomp failed for jsapi.c
gmake[1]: *** [jsapi.o] Error 2

Comment 1

[Alfred Peng]

Attachment: Patch v1

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 244180 [details] [diff] [review]
Patch v1

Igor, what compiler let this past?

/be

Comment 3

[Igor Bukanov]

(In reply to comment #2)
> (From update of attachment 244180 [details] [diff] [review] [edit])
> Igor, what compiler let this past?

@callisto~/s> gcc -c -Wall -O3 -Wextra a.c
@callisto~/s> gcc -c -Wall -Wextra a.c
@callisto~/s> cat a.c
void f();

void g()
{
    return f();
}
@callisto~/s> gcc --version
gcc (GCC) 4.1.2 20060928 (prerelease) (Ubuntu 4.1.1-13ubuntu5)
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Comment 4

[Igor Bukanov]

Comment on attachment 244180 [details] [diff] [review]
Patch v1

I underestimated the jet leg influence on my brain :(

Comment 5

[Igor Bukanov]

From GCC mail list: the bug is fixed in GCC 4.2 and it is a valid C++ code.

Comment 6

[Alfred Peng]

Could anyone help me check in the patch? brendan?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/js/src/jsapi.c 	3.287

Comment 8

[Brendan Eich [:brendan]]

*** Bug 359038 has been marked as a duplicate of this bug. ***

Comment 9

[Igor Bukanov]

The committed patch for bug 357169 on 1.8.1 branch contained the fix.

Comment 10

[Jay Patel [:jay]]

Alfred:  Can you please help us verify this fix?  If you are able to successfully build now (which I'm assuming you are), please replace the "fixed1.8.1.1" keyword with "verified1.8.1.1".  Thanks!

Comment 11

[Alfred Peng]

Build successfully on my system: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1.1pre) Gecko/20061201 BonEcho/2.0.0.1pre.