359057 - If the XSL page specified for an XML page fails to parse the XML or is absent, View->Page Source is disabled.

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Mark Bidewell]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050225 Netscape/8.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050225 Netscape/8.0

If the XSL page specified for an XML page cannot be retrived the XML source cannot be viewed because the "View Source" option is greyed out. (Tested on FF2 Windows and Linux

Reproducible: Always

Steps to Reproduce:
1. Navigate to an xml page with broken XSL link
2. Try to click on "View Source"


Actual Results:  
Cannot view source

Expected Results:  
Source should be able to be viewed

Comment 1

[Mark Bidewell]

occurs on any xsl failure

Comment 2

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070619 Minefield/3.0a6pre - confirmed; only in View menu
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/2007061901 SeaMonkey/2.0a1pre - confirmed; both in View and context menu
without XSL, the file is loading indefinitely, and Page Source is active; if you stop the loading, Page Source gets disabled.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.5pre) Gecko/20070615 BonEcho/2.0.0.5pre - confirmed; only in View menu
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.5pre) Gecko/20070611 SeaMonkey/1.1.2 - confirmed; both in View and context menu

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20070612 SeaMonkey/1.0.9 - confirmed; both in View and context menu

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20070619 Firefox/1.5.0.13pre - WFM

Firefox trunk regression range:
tr2005091805 - wfm
tr2005091905 - cfm in View
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-09-18+05%3A00%3A00&maxdate=2005-09-19+06%3A00%3A00&cvsroot=%2Fcvsroot

Firefox 1.8 regression range:
2006013004 - wfm
2006013104 - cfm in View
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-01-30+04%3A00%3A00&maxdate=2006-01-31+05%3A00%3A00&cvsroot=%2Fcvsroot

Seems to have been caused by the fix in bug 294383.

Comment 3

[Boris Zbarsky [:bzbarsky]]

data:text/xml,<?xml-stylesheet%20type="text/xsl"%20href="data:text/xsl,broken"?><root/>

seems to work fine for me.  Please attach a testcase that shows the problem?

Comment 4

[[:Aleksej]]

With, I think, the same file (<http://mikeshea.net/vrenna_and_other_tales.atom.xml> saved locally without the xsl nearby).

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre) Gecko/2007112604 Minefield/3.0b2pre
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre) Gecko/2007112602 SeaMonkey/2.0a1pre

WFM with both menus and the hot key.

Comment 5

[nemo]

Ran into this as well.
http://m8y.org/demo.xml
A trivial file with an invalid XSLT.
Being unable to view source is annoying when trying to figure out what happened.

Comment 6

[[e-mail]]

(In reply to comment #3)
>data:text/xml,<?xml-stylesheet%20type="text/xsl"%20href="data:text/xsl,broken"?><root/>
>seems to work fine for me.
Except for the security exception in the error console. Ouch.

Looking at the resulting document its content type is the empty string. Oops.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Testcase from comment #5 shows the problem nicely; note that manually loading view-source:http://... works as expected (and is a workaround, albeit an undiscoverable one).

Comment 8

[Justin [:JW_SoftvisionQA]]

I can not reproduce this issue with the page http://m8y.org/demo.xml listed in comment 5. I will close this issue as works for me. Please reopen if you can still reproduce.

Comment 9

[nemo]

Tested in nightly and stable, e10s and non, and does indeed seem to be fixed.
There was a fair amount of recent work w/ e10s view source and view source in tabs.  Since manually entering a view-source url worked before, the fact that the context menu now opens a view-source: tab might be why it's fine now.