Closed Bug 359209 Opened 18 years ago Closed 8 years ago

nsSecretDecoderRing::Encrypt and nsSecretDecoderRing::EncryptString violate xpcom memory management rules

Categories

(Core :: Security: PSM, defect)

Product:
Core
Component:
Security: PSM
Platform:
x86
SunOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 486404

People

(Reporter: timeless, Unassigned)

References

(
URL
)

Details

xpcom says that the allocator must be nsMemory (or an alias), but sdr chains to PK11SDR_Decrypt which happens to use an Arena to allocate as well as encode which uses PR_Malloc.

To guarantee corruption, nsSecretDecoderRing::EncryptString tries to use nsMemory::Free when things go wrong (that's freeing something which should be coming from the arena).
QA Contact: psm
reassign bug owner.
mass-update-kaie-20120918
Assignee: kaie → nobody
Looks like this got fixed in bug 486404.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.