Compiling in xpcom results in the following error on my system: xpcomcomponents_s.lib(nsStaticComponentLoader.obj) : error LNK2005: "protected: __thiscall nsTArray_base::nsTArray_base(void)" (??0nsTArray_base@@IAE@XZ) alread y defined in nsTArray.obj Creating library xpcom_core.lib and object xpcom_core.exp xpcom_core.dll : fatal error LNK1169: one or more multiply defined symbols found make: *** [xpcom_core.dll] Error 145 This error is resolved by including nsTraceRefcnt.h in nsTArray.h.
Hmm... I guess the header does need the #define and the #define comes from nsTraceRefCnt.h.... I'm really not that happy including it here, but if there's no better way then we should, I guess.
Yeah, I don't see another way other than to move the define to another header.
Checked in for Alex.
Created attachment 244516 [details] [diff] [review] Remove pointless include This should have gone in with the other patch, no?
Checked in the .cpp patch.