Include nsTraceRefcnt.h in nsTArray.h

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
11 years ago
7 years ago

People

(Reporter: Alex Menzies, Assigned: Alex Menzies)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Compiling in xpcom results in the following error on my system:

xpcomcomponents_s.lib(nsStaticComponentLoader.obj) : error LNK2005: "protected: __thiscall nsTArray_base::nsTArray_base(void)" (??0nsTArray_base@@IAE@XZ) alread
y defined in nsTArray.obj
   Creating library xpcom_core.lib and object xpcom_core.exp
xpcom_core.dll : fatal error LNK1169: one or more multiply defined symbols found
make[2]: *** [xpcom_core.dll] Error 145

This error is resolved by including nsTraceRefcnt.h in nsTArray.h.
(Assignee)

Comment 1

11 years ago
Created attachment 244464 [details] [diff] [review]
patch
Hmm...  I  guess the header does need the #define and the #define comes from nsTraceRefCnt.h....

I'm really not that happy including it here, but if there's no better way then we should, I guess.
Yeah, I don't see another way other than to move the define to another header.
(Assignee)

Updated

11 years ago
Attachment #244464 - Flags: review?(darin.moz)
Attachment #244464 - Flags: superreview+
Attachment #244464 - Flags: review?(darin.moz)
Attachment #244464 - Flags: review+

Comment 4

11 years ago
Checked in for Alex.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Created attachment 244516 [details] [diff] [review]
Remove pointless include

This should have gone in with the other patch, no?
Attachment #244516 - Flags: superreview?(bugmail)
Attachment #244516 - Flags: review?(bugmail)
Attachment #244516 - Flags: superreview?(bugmail)
Attachment #244516 - Flags: superreview+
Attachment #244516 - Flags: review?(bugmail)
Attachment #244516 - Flags: review+
Checked in the .cpp patch.

Updated

7 years ago
Assignee: nobody → malex
You need to log in before you can comment on or make changes to this bug.