359464 - static tinderbox pages "show previous" links busted

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I did find another minor bug with the static tinderbox pages:

http://tinderbox.mozilla.org/Firefox/

The "Show previous * hours" links at the bottom of the table are broken in the following ways:

 * the first of the two links should say "Show previous 12 hours" instead of "Show previous hours"

 * both links should have a maxdate= corresponding to the bottom of the display, not the top.  Currently their maxdate makes them show the current 12/24 hours, not the previous 12/24.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

And I think the line below it has the same maxdate problem.

Comment 2

[cls]

Attachment: v1.0

This patch fixes the first problem.

The second problem isn't directly related to static pages.  The cgi version of those pages use the current maxdate for those links as well (same subroutines).  Modifying that would change the historical behavior of those links, which, admittedly may be buggy as well.

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 244637 [details] [diff] [review]
v1.0

I love global variables, don't you?  :/ ;)

Comment 4

[cls]

Checking in webtools/tinderbox/processbuild.pl;
/cvsroot/mozilla/webtools/tinderbox/processbuild.pl,v  <--  processbuild.pl
new revision: 1.62; previous revision: 1.61
done

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

No, the second problem is different on the static pages -- and the showbuilds.cgi pages are showing the correct historical behavior and the static ones are wrong.

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

But I think this patch will fix the second problem as well, since that date was generated with:

  my $nextdate = $maxdate - $hours*60*60;

in print_table_footer.

Comment 7

[cls]

When I go to http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox and hover over the 'Show previous' links, I see the same maxdate in both links.  These maxdates are different than the ones in the 'show from previous weeks' links.

http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox&maxdate=1162560471&legend=0
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox&hours=24&maxdate=1162560471&legend=0

If I go to http://tinderbox-old.mozilla.org/showbuilds.cgi?tree=Firefox , I see the same behavior.

In all cases with patch v1.0 applied, clicking on the links takes you to 12 & 24 hrs in the past respectively.  The unmodified maxdate results in all checkins up to current being reflected in the guilty column rather than just the checkins between the times currently listed on the page.  That is the historical behavior.  What behavior are you seeing?

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Yep, now that it's live, that patch fixed both problems, and also fixed the problem that the "C" links weren't showing up on the static pages.