Closed Bug 359469 Opened 18 years ago Closed 18 years ago

Undo the changes to make offline support a (non-optional) extension

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird2.0

People

(Reporter: mscott, Assigned: mscott)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

the fix
50.69 KB, patch
Bienvenu
: superreview+
mscott
: approval-thunderbird2+
Details | Diff | Splinter Review
cleanup patch
863 bytes, patch
mscott
: review+
mscott
: approval-thunderbird2+
Details | Diff | Splinter Review 
Back in the early days I ripped out the offline UI and made it an extension. But we ended up making it a required extension anyway (the installer doesn't let you opt out of it). 

It was a silly decision and we don't need to treat it as an extension. Let's put it back the way it was.
Attached patch the fix — — Splinter Review 
remove offline.jar, integrate it back into the main UI.
Attachment #244641 - Flags: superreview?(bienvenu)
I tested this against a clobber build.
Attachment #244641 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 244641 [details] [diff] [review]
the fix

fixed on the trunk. I want to make sure the installer and update changes work ok on the trunk before landing on the branch.
Attachment #244641 - Flags: approval-thunderbird2?
Comment on attachment 244641 [details] [diff] [review]
the fix

today's trunk installer and software update worked ok after this change (I tested on windows) so I'm checking this into the branch too.
Attachment #244641 - Flags: approval-thunderbird2? → approval-thunderbird2+
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird2.0
Attached patch cleanup patch — — Splinter Review 
"mail/extensions/offline/Makefile" remains in "allmakefiles.sh".
Attachment #245089 - Flags: review?(mscott)
Comment on attachment 245089 [details] [diff] [review]
cleanup  patch

good catch!
Attachment #245089 - Flags: review?(mscott)
Attachment #245089 - Flags: review+
Attachment #245089 - Flags: approval-thunderbird2+
Thank you Hiro-san. Patch checked into the branch and trunk.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: