Closed Bug 359606 Opened 14 years ago Closed 14 years ago

Disable mozreg_s from XULRUNNER embedding-profile=minimal

Categories

(Toolkit Graveyard :: Build Config, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file, 1 obsolete file)

Building xulrunner trunk with 
embedding-profile=minimal failed with message:

....................
make[1]: *** No rule to make target `../../dist/lib/libmozreg_s.a', needed by `libxul.so'.  Stop.
make: *** [default] Error 2
...................

I think for embedding level < MOZ_EMBEDDING_LEVEL_DEFAULT  we should remove mosreg_s...


See patch in attachment
Attached patch BUGFIX (obsolete) — Splinter Review
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #244766 - Flags: first-review?
Attachment #244766 - Flags: second-review?(benjamin)
Attachment #244766 - Flags: first-review?(benjamin)
Attachment #244766 - Flags: first-review?
Attachment #244766 - Flags: second-review?(benjamin)
Attachment #244766 - Flags: first-review?(benjamin)
Attachment #244766 - Flags: first-review+
Tested with FF/SM/XULRUNNER build
Attachment #270914 - Flags: review?
Whiteboard: [checkin needed]
why are you now using #ifdef and you weren't before?
Keywords: checkin-needed
Whiteboard: [checkin needed]
Attachment #270914 - Flags: review? → review?(benjamin)
Attachment #270914 - Flags: review?(benjamin) → review+
Whiteboard: [checkin needed]
It appears after building in different configurations, FF/Xulrunner
Keywords: checkin-needed
Whiteboard: [checkin needed]
Committed the second patch, was it the right thing to do?

Checking in toolkit/library/libxul-config.mk;
/cvsroot/mozilla/toolkit/library/libxul-config.mk,v  <--  libxul-config.mk
new revision: 1.50; previous revision: 1.49
done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta1
Attachment #244766 - Attachment is obsolete: true
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.