359606 - Disable mozreg_s from XULRUNNER embedding-profile=minimal

Status: RESOLVED FIXED

(Toolkit Graveyard :: Build Config, defect)

Description

[Oleg Romashin (:romaxa)]

Building xulrunner trunk with 
embedding-profile=minimal failed with message:

....................
make[1]: *** No rule to make target `../../dist/lib/libmozreg_s.a', needed by `libxul.so'.  Stop.
make: *** [default] Error 2
...................

I think for embedding level < MOZ_EMBEDDING_LEVEL_DEFAULT  we should remove mosreg_s...


See patch in attachment

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: BUGFIX

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: BUGFIX: Could we commit this?

Tested with FF/SM/XULRUNNER build

Comment 3

[Shawn Wilsher :sdwilsh]

why are you now using #ifdef and you weren't before?

Comment 4

[Oleg Romashin (:romaxa)]

It appears after building in different configurations, FF/Xulrunner

Comment 5

[Nickolay_Ponomarev]

Committed the second patch, was it the right thing to do?

Checking in toolkit/library/libxul-config.mk;
/cvsroot/mozilla/toolkit/library/libxul-config.mk,v  <--  libxul-config.mk
new revision: 1.50; previous revision: 1.49
done