359659 - ja search partner NTT goo has their search suggest ready for 2.0.0.1

Status: VERIFIED FIXED

(Mozilla Localizations :: ja / Japanese, enhancement)

Description

[Gen Kanai [:gen]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; ja-JP-mac; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; ja-JP-mac; rv:1.8.1) Gecko/20061010 Firefox/2.0

Our search partner for ja, NTT goo, http://www.goo.ne.jp/ has their search suggest plugin ready for 2.0.0.1 ja-JP.

As soon as I have the code, I will have it added.

Reproducible: Always

Comment 1

[Kohei Yoshino [:kohei]]

Attachment: goo search plug-in with suggest feature

Here is the new search plug-in from goo.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 244980 [details]
goo search plug-in with suggest feature

I'd rather see a patch for this. 
cvs -z3 diff -u goo.xml
should work, even on anonymous check-outs.

Comment 3

[Kohei Yoshino [:kohei]]

My flags were incorrect. dynamis will handle this.

Comment 4

[dynamis (Tomoya ASAI)]

Attachment: goo search plug-in with suggest feature

Previous attachment included some additional changes which is not reuired and this is the right new plugin.
I'll attach a patch too.

Comment 5

[dynamis (Tomoya ASAI)]

Attachment: diff of the goo search plugin

This is the diff against current goo plugin.
Just add one line, which is URL entity specifying suggestion service url.

Requesting approval1.8.1.1

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 245581 [details] [diff] [review]
diff of the goo search plugin

[ja/ja-JP-mac] approval to add suggest for the goo search plugin.

Comment 7

[Axel Hecht [:Pike]]

[mass-verified1.8.1.1 message, filter on this if you need to]

This bug has an approved patch, but not the verified1.8.1.1 keyword.

Please make sure that the approved patch is landed (add the fixed1.8.1.1 keyword then) and tested. If you verified that the bug in question is indeed fixed on the 1.8 branch nightlies, please add the verified1.8.1.1 keyword.

We need to get the QA activities around Firefox 2.0.0.1 up to speed so that we can feel good about releasing this update.

Comment 8

[dynamis (Tomoya ASAI)]

I verified the fix with latest nightly builds.

-> RESOLVED FIXED verified1.8.1.1