359718 - Page info : Security tab never shown.

Status: VERIFIED FIXED

(Firefox :: Page Info Window, defect, P1)

Description

[Florian Quèze [:florian]]

The "Security" tab of page info is never shown.
The patch in bug 356590 caused this bug.
See http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/manager/pki/resources/content/PageInfoOverlay.xul&rev=1.24#63

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Comment on attachment 245624 [details] [diff] [review]
patch

Darin, could you please moa this, kaie seems to be away?

Comment 3

[Asaf Romano (gone)]

s/\?/\./

Comment 4

[Darin Fisher]

Comment on attachment 245624 [details] [diff] [review]
patch

OK, but I don't know this code.

Comment 5

[Asaf Romano (gone)]

mozilla/security/manager/pki/resources/content/PageInfoOverlay.xul 1.27

Comment 6

[Kai Engert (:KaiE:)]

You said bug 356590 caused this bug.
Bug 356590 only changed firefox specific code (directory browser).

Question: Will this patch work correctly for other products like SeaMonkey?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> Question: Will this patch work correctly for other products like SeaMonkey?

Yes. All that bug 356590 changed is that /browser code now always pass in a window, even when no frames are involved. The /security code made the assumption that a passed in window was a frame, we just removed that assumption and made it check. This should have no effect for SeaMonkey, since they only pass windows for frames.

Comment 8

[Tanner M. Young [:tmyoung]]

Verified Fixed.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091205 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20091205042811