359722 - NPNetscapeFuncs size change handled non-backwards compatibly in npunix.c

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[William Bardwell]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20060211 Fedora/1.0.7-1.3.fc3.legacy Firefox/1.0.7
Build Identifier: 

The npunix.c file in ./modules/plugin/samples/default/unix/npunix.c has code which just fails if run under an older browser.  It refuses to initialize the function table if the size of the table passed in is smaller than the size of the NPNetscapeFuncs.  And the code unconditionally copies pushpopupsenabledstate and poppopupsenabledstate.  This means that compiling a plugin with that makes a plugin that won't work under older browser

Reproducible: Always

Steps to Reproduce:
1. build a plugin against npunix.c
2. run under older browser (like FireFox 1.0)
3. have plugin fail to initialize.



Expected Results:  
It should instead see if those functions are available, and if so copy them, if not don't.

Comment 1

[William Bardwell]

Attachment: Patch that I am using to deal with this problem.

Comment 2

[Frank Wein [:mcsmurf]]

This is a result of Bug 301052.

Comment 3

[aravindm]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.4) Gecko/20100413 Firefox/3.6.4
Please update if you are able to still reproduce with the latest nightly build  ftp://ftp.mozilla.org/pub/firefox/nightly/latest-trunk/

Comment 4

[William Bardwell]

It looks like the fix for Bug 301052 fixes this bug as well.  (It looks Firefox 3.0 and newer have a npunix.c that is fixed.)