Times, Courier and Helvetica shouldn't be hardcoded in the preference

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: alfred.peng, Assigned: alfred.peng)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Times, Courier and Helvetica are hardcoded in the preference(all.js). These fonts are not free and they are Type 1 fonts. On some platforms(like Solaris), TrueType fonts should be used instead.
Replace the preferences with serif, sans-serif, monospace. The platforms will resolve the fonts to the corresponding ones.
(Assignee)

Comment 1

12 years ago
Created attachment 244872 [details] [diff] [review]
Patch v1
Assignee: nobody → alfred.peng
Status: NEW → ASSIGNED
Attachment #244872 - Flags: superreview?(roc)
Attachment #244872 - Flags: review?(benjamin)

Comment 2

12 years ago
Comment on attachment 244872 [details] [diff] [review]
Patch v1

I am not the right person to review this patch, please ask jshin. But isn't the whole point of these prefs to set the *default* font used for serif/sans-serif/monospace? I certainly don't have a font named "sans-serif" on my system.
Attachment #244872 - Flags: review?(benjamin)
(Assignee)

Comment 3

12 years ago
This patch just sets the prefs to select the default font, not Times, Courier and Helvetica. XFT will handle the font selection by using this patch.
(Assignee)

Updated

12 years ago
Attachment #244872 - Flags: review?(jshin1987)
(Assignee)

Comment 4

12 years ago
jshin, any suggestions for this patch?
(Assignee)

Comment 5

12 years ago
roc, opinions for this patch?
Karl, didn't you just write a patch like this?
Thanks.  Exact same patch from here was checked in:

https://bugzilla.mozilla.org/show_bug.cgi?id=379886#c5
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Depends on: 379886
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Attachment #244872 - Flags: review?(jshin1987)
Blocks: 334565
Blocks: 365680
You need to log in before you can comment on or make changes to this bug.