359777 - Times, Courier and Helvetica shouldn't be hardcoded in the preference

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Alfred Peng]

Times, Courier and Helvetica are hardcoded in the preference(all.js). These fonts are not free and they are Type 1 fonts. On some platforms(like Solaris), TrueType fonts should be used instead.
Replace the preferences with serif, sans-serif, monospace. The platforms will resolve the fonts to the corresponding ones.

Comment 1

[Alfred Peng]

Attachment: Patch v1

Comment 2

[Benjamin Smedberg]

Comment on attachment 244872 [details] [diff] [review]
Patch v1

I am not the right person to review this patch, please ask jshin. But isn't the whole point of these prefs to set the *default* font used for serif/sans-serif/monospace? I certainly don't have a font named "sans-serif" on my system.

Comment 3

[Alfred Peng]

This patch just sets the prefs to select the default font, not Times, Courier and Helvetica. XFT will handle the font selection by using this patch.

Comment 4

[Alfred Peng]

jshin, any suggestions for this patch?

Comment 5

[Alfred Peng]

roc, opinions for this patch?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Karl, didn't you just write a patch like this?

Comment 7

[Karl Tomlinson (:karlt)]

Thanks.  Exact same patch from here was checked in:

https://bugzilla.mozilla.org/show_bug.cgi?id=379886#c5