No reason to use XUL based button in netError.xhtml

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
12 years ago
7 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
I think there are no any reasons for using XUL button in 
mozilla/docshell/resources/content/netError.xhtml
This page is customizable by the embeddor, no?  The default page uses XUL to fit in with the most common (XUL) Gecko UIs.
(Assignee)

Comment 2

12 years ago
Created attachment 244895 [details] [diff] [review]
Patch (XUL button -> simple button)
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #244895 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #244895 - Flags: review? → review?(timeless)
Comment on attachment 244895 [details] [diff] [review]
Patch (XUL button -> simple button)

This breaks keyboard usage.  And timeless is not an owner for this code.

Again, I fail to see why you're changing this file at all.
Attachment #244895 - Flags: review?(timeless) → review-
(Assignee)

Comment 4

12 years ago
> Again, I fail to see why you're changing this file at all.

Because i trying to use this page, for showing network errors with full description.... In xul disabled configuration... but there are only one XUL element - button.

I can't understand, why we should use another netError.xhtml... if we can use this?

I think xul element on this page - useless.. is not so?


Because the point is that this page should look as much like the browser UI as possible.  The default is optimized for the most common uses.  That, and using a XUL button gives much better accessibility, of course.

Comment 6

12 years ago
And if you've ever seen a HTML button on mac (Firefox), you'll see that it looks awful, compared to XUL buttons...

Comment 7

11 years ago
if you have xbl, you could bind xul:button to html:button....
(Assignee)

Comment 8

11 years ago
Yes I have, but how and where I can do it (binding)?

on top of netError.xhtm, like:
<binding ...

?

Comment 9

11 years ago
my guess is that you could put the binding in userContent.css you'd somehow want to do it for all builds w/ disable xul. It probably isn't preprocessed right now...
There's no chance for the patch to be checked in, because this has already been resolved by bug 546857. And attachment 465072 [details] [diff] [review] contains something exactly same as attachment 244895 [details] [diff] [review].
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.