Closed
Bug 359812
Opened 18 years ago
Closed 13 years ago
No reason to use XUL based button in netError.xhtml
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: romaxa, Assigned: romaxa)
Details
Attachments
(1 file)
1.02 KB,
patch
|
bzbarsky
:
review-
|
Details | Diff | Splinter Review |
I think there are no any reasons for using XUL button in mozilla/docshell/resources/content/netError.xhtml
Comment 1•18 years ago
|
||
This page is customizable by the embeddor, no? The default page uses XUL to fit in with the most common (XUL) Gecko UIs.
Assignee | ||
Comment 2•18 years ago
|
||
Assignee | ||
Updated•18 years ago
|
Attachment #244895 -
Flags: review? → review?(timeless)
Comment 3•18 years ago
|
||
Comment on attachment 244895 [details] [diff] [review] Patch (XUL button -> simple button) This breaks keyboard usage. And timeless is not an owner for this code. Again, I fail to see why you're changing this file at all.
Attachment #244895 -
Flags: review?(timeless) → review-
Assignee | ||
Comment 4•18 years ago
|
||
> Again, I fail to see why you're changing this file at all.
Because i trying to use this page, for showing network errors with full description.... In xul disabled configuration... but there are only one XUL element - button.
I can't understand, why we should use another netError.xhtml... if we can use this?
I think xul element on this page - useless.. is not so?
Comment 5•18 years ago
|
||
Because the point is that this page should look as much like the browser UI as possible. The default is optimized for the most common uses. That, and using a XUL button gives much better accessibility, of course.
Comment 6•18 years ago
|
||
And if you've ever seen a HTML button on mac (Firefox), you'll see that it looks awful, compared to XUL buttons...
Assignee | ||
Comment 8•17 years ago
|
||
Yes I have, but how and where I can do it (binding)? on top of netError.xhtm, like: <binding ... ?
my guess is that you could put the binding in userContent.css you'd somehow want to do it for all builds w/ disable xul. It probably isn't preprocessed right now...
Comment 10•13 years ago
|
||
There's no chance for the patch to be checked in, because this has already been resolved by bug 546857. And attachment 465072 [details] [diff] [review] contains something exactly same as attachment 244895 [details] [diff] [review].
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•