Closed
Bug 359850
Opened 19 years ago
Closed 19 years ago
fix shell xcodeproj
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: shaver, Assigned: shaver)
Details
Attachments
(1 file, 1 obsolete file)
|
18.52 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
Two things:
- remove the zlib references (the core framework has what it needs there)
- hide all the JNI bits behind AVMPLUS_WITH_JNI
Patch incoming.
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Attachment #244910 -
Flags: review? → review?(crowder)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 244910 [details] [diff] [review]
Fix
r=stejohns@adobe.com
Note that Release builds still fail to link; only Debug builds succeed with this patch
Attachment #244910 -
Flags: review?(crowder) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
I added libz.dylib to the build, which I should have done hours ago -- I believe that something in the Debug config was pulling it in implicitly, possibly in one of the sub libs, and that's why the Debug build was sneaking through to completion.
Attachment #244910 -
Attachment is obsolete: true
Attachment #244921 -
Flags: review?(stejohns)
|
|
||
Comment 4•19 years ago
|
||
Comment on attachment 244921 [details] [diff] [review]
Fix release builds as well.
r=stejohns
Attachment #244921 -
Flags: review?(stejohns) → review+
|
|
Assignee | |
Comment 5•19 years ago
|
||
Committed, thanks.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•18 years ago
|
||
Transfer Bug from Core->Tamarin to Tamarin Product.
Component: Tamarin → Virtual Machine
Product: Core → Tamarin
Version: 1.8 Branch → unspecified
|
|
||
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•