359880 - Add param "aq=t" to the Google search engine spec

Status: RESOLVED FIXED

(Firefox :: Search, enhancement)

Description

[Joe Hughes]

The Google search folks would like us to add an "aq=t" parameter to Google search queries that originate from the searchbar.  (This parameter identifies the query as coming from a suggest-enabled searchbox.)

Comment 1

[Joe Hughes]

Attachment: Adds the parameter

Comment 2

[Joe Hughes]

We also need to update any other localized versions of the Google plugin (only Japan at this point?).

Comment 3

[Axel Hecht [:Pike]]

affected versions would be ja, ja-JP-mac, and ar.

Comment 4

[Axel Hecht [:Pike]]

Wrong mic, sorry.

Mic, could you see which pages we need to update to protocol this change in search?
rhelmer probably needs to add this to his checks, too.

Comment 5

[Mic Berman]

axel,
you mean which search page requirements we need to change? in that case i believe it would be...http://wiki.mozilla.org/Firefox2/L10n_Requirements
please advise
mic

Comment 6

[Axel Hecht [:Pike]]

At least, yes. I'm not exactly sure what we have on the intranet.

Do we have the arabic and japanese plugin deviations documented somewhere?

Comment 7

[Mic Berman]

here's what we have (that i know about) on the intranet and I don't believe that it makes sense to document it there, lmk if you disagree
https://intranet.mozilla.org/Trademark_L10n_Review-Firefox2#Search_Plug-ins

if this is a new requirements to create this documentation, lmk

Comment 8

[Joe Hughes]

Attachment: Makes the required change to ja and ja-JP-mac localizations

I don't believe that the ar localization's plugin needs to be updated because it doesn't have Suggest activated.

Comment 9

[Mic Berman]

I don't know if this is the complete list of Google search suggest locales, this was not a requirement I had documented. Axel, do you know for sure if this it the complete list? if yes, great, if not, I'll follow up with our contact at Google to be sure.

Comment 10

[Mike Connor [:mconnor]]

Joe's been our liason to the Suggest team.  Currently en and jp are the only locales with active suggest results.  Not sure why AR has suggest, that'll get english results afaict.

We should definitely track this in the searchplugin reqs.

Comment 11

[Mike Connor [:mconnor]]

As an added note: we should track this for all searchplugins, since any searchplugin can implement it (Yahoo/Answers/one of the Japanese engines (goo?) already do so).

Comment 12

[Mic Berman]

ok, will track going forward.

Comment 13

[Mike Connor [:mconnor]]

We need to get this resolved by 2.0.0.2

Mic/Axel, can you do whatever you need to do here?

Comment 14

[Mic Berman]

will do

Comment 15

[Joe Hughes]

Ping: still waiting on L10N approval on these patches (also, I think technically mconnor needs to SR+ the English patch).

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 249792 [details] [diff] [review]
Makes the required change to ja and ja-JP-mac localizations

We should really kill that flag, I don't look at it anymore. Doing an r+ instead.

Comment 17

[Joe Hughes]

Assuming that we now have all the relevant approvals, could someone with l10n checkin approval land these patches?

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Both patches need 1.8.1 branch driver approval (approval1.8.1.2) for landing on the 1.8 branch. The en-US patch can land on the trunk now; the l10n patch doesn't apply to the trunk.

Comment 19

[Daniel Veditz [:dveditz]]

Comment on attachment 244942 [details] [diff] [review]
Adds the parameter

approved for 1.8 branch, a=dveditz for drivers

Comment 20

[Daniel Veditz [:dveditz]]

Comment on attachment 249792 [details] [diff] [review]
Makes the required change to ja and ja-JP-mac localizations

approved for the 1.8-l10n branch, a=dveditz for drivers

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 249792 [details] [diff] [review]
Makes the required change to ja and ja-JP-mac localizations

I landed the l10n patch on the branch, 

Checking in ja/browser/searchplugins/google-jp.xml;
/l10n/l10n/ja/browser/searchplugins/Attic/google-jp.xml,v  <--  google-jp.xml
new revision: 1.1.2.7; previous revision: 1.1.2.6
done
Checking in ja-JP-mac/browser/searchplugins/google-jp.xml;
/l10n/l10n/ja-JP-mac/browser/searchplugins/Attic/google-jp.xml,v  <--  google-jp.xml
new revision: 1.1.2.6; previous revision: 1.1.2.5
done

Comment 22

[Joe Hughes]

Thanks, Axel!

Comment 23

[Joe Hughes]

I just landed the en-US patch on branch & trunk.

Comment 24

[Tony Chung [:tchung]]

Verified fix on 1.8.1.2