User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061106 Camino/1.1a1+ Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061106 Camino/1.1a1+ Bookmarks deleted from the bookmarks panel are not deleting from the bookmarks drop-down menu. I suspect that it may be related to the corrections made in result to bug 359662 https://bugzilla.mozilla.org/show_bug.cgi?id=359662 however I can't confirm this. Reproducible: Always Steps to Reproduce: 1. Click 'Show All Bookmarks' 2. Delete A Bookmark 3. Exit Bookmarks Panel 4. Click Bookmarks Drop-Down Menu Expected Results: It's expected that bookmarks deleted from the bookmarks panel would also delete from the bookmarks drop-down menu. Example appended.
Created attachment 244976 [details] Screenshot of Bug You can see where the bookmark has been removed from the bookmarks panel, but still appears in the bookmarks drop-down menu.
Doesn't seem to happen every time.
Created attachment 244977 [details] Screenshot of Bug 2 Bookmark 'Seven Reasons the 21st Century is Making You Miserable' has been deleted from the bookmarks panel, but still appears in the bookmarks drop-down menu between 'TheStar' and 'strange maps'
I'm not sure how related this is to bug 359662 (other than by the fact that we build the bookmarks menu lazily, which is on purpose). From what I can see, the menu is being updated correctly when creating, moving, or copying bookmarks, but not when deleting. This doesn't seem to occur in 1.0.3, so confirming as a regression and tweaking summary to use the standard terminology.
"related to the corrections made in result to bug 359662" I need to read more carefully. It's absolutely not that, since that bug hasn't landed yet.
Off the top of my head, hwaara's work to optimize bookmark deletion might be a good first place to look.
Can someone come up with a 100% reproducible & simple testcase for seeing this bug?
This is 100% reproable for me with these steps: 1. Cmd-B. Make sure you're looking at the bookmarks menu collection 2. Option-drag an existing bookmark to duplicate it. Examine the bookmarks menu (both bookmarks are visible) 3. Hit the delete key. Examine bookmarks menu. What happens: Still displays duplicate bookmarks.
Created attachment 245269 [details] [diff] [review] fix This was a latent bug triggered by the fast-deletion changes; the bookmark menu has apparently never handled the childen-changed notification.
Comment on attachment 245269 [details] [diff] [review] fix Håkan, can you look at this soonish?
Comment on attachment 245269 [details] [diff] [review] fix Looks good!
Comment on attachment 245269 [details] [diff] [review] fix sr=pink
Checked in on trunk and MOZILLA_1_8_BRANCH.