359907 - Bookmarks Aren't Deleted from Bookmarks Menu After Deletion from Bookmarks Manager

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Hayden]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061106 Camino/1.1a1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061106 Camino/1.1a1+

Bookmarks deleted from the bookmarks panel are not deleting from the bookmarks drop-down menu.

I suspect that it may be related to the corrections made in result to bug 359662 https://bugzilla.mozilla.org/show_bug.cgi?id=359662 however I can't confirm this.

Reproducible: Always

Steps to Reproduce:
1. Click 'Show All Bookmarks'
2. Delete A Bookmark
3. Exit Bookmarks Panel
4. Click Bookmarks Drop-Down Menu



Expected Results:  
It's expected that bookmarks deleted from the bookmarks panel would also delete from the bookmarks drop-down menu.

Example appended.

Comment 1

[Hayden]

Attachment: Screenshot of Bug

You can see where the bookmark has been removed from the bookmarks panel, but still appears in the bookmarks drop-down menu.

Comment 2

[Hayden]

Doesn't seem to happen every time.

Comment 3

[Hayden]

Attachment: Screenshot of Bug 2

Bookmark 'Seven Reasons the 21st Century is Making You Miserable' has been deleted from the bookmarks panel, but still appears in the bookmarks drop-down menu between 'TheStar' and 'strange maps'

Comment 4

[froodian (Ian Leue)]

I'm not sure how related this is to bug 359662 (other than by the fact that we build the bookmarks menu lazily, which is on purpose).

From what I can see, the menu is being updated correctly when creating, moving, or copying bookmarks, but not when deleting.

This doesn't seem to occur in 1.0.3, so confirming as a regression and tweaking summary to use the standard terminology.

Comment 5

[froodian (Ian Leue)]

"related to the corrections made in result to bug 359662"

I need to read more carefully.  It's absolutely not that, since that bug hasn't landed yet.

Comment 6

[Stuart Morgan]

Off the top of my head, hwaara's work to optimize bookmark deletion might be a good first place to look.

Comment 7

[Håkan Waara]

Can someone come up with a 100% reproducible & simple testcase for seeing this bug?

Comment 8

[froodian (Ian Leue)]

This is 100% reproable for me with these steps:

1. Cmd-B.  Make sure you're looking at the bookmarks menu collection
2. Option-drag an existing bookmark to duplicate it.  Examine the bookmarks menu (both bookmarks are visible)
3. Hit the delete key.  Examine bookmarks menu.

What happens: Still displays duplicate bookmarks.

Comment 9

[Stuart Morgan]

Attachment: fix

This was a latent bug triggered by the fast-deletion changes; the bookmark menu has apparently never handled the childen-changed notification.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 245269 [details] [diff] [review]
fix

Håkan, can you look at this soonish?

Comment 11

[Håkan Waara]

Comment on attachment 245269 [details] [diff] [review]
fix

Looks good!

Comment 12

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 245269 [details] [diff] [review]
fix

sr=pink

Comment 13

[Stuart Morgan]

Checked in on trunk and MOZILLA_1_8_BRANCH.