359960 - accessibility.typeaheadfind.linksonly==true breaks Find in View Source

Status: RESOLVED DUPLICATE of bug 375171

(Toolkit :: Find Toolbar, defect)

Description

[Timwi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

See STR.

Reproducible: Always

Steps to Reproduce:
1. Go to http://bugzilla.mozilla.org/
2. Press Ctrl+U. View Source window appears.
3. Press Ctrl+F. Find Toolbar appears.
4. Press x.

Actual Results:  
Find Toolbar goes red and says "Text not found".

Expected Results:  
Should jump to (and highlight) first occurrence of "x" in the source text, in this example the one in "emailtype1=exact".

Comment 1

[Ria Klaassen (not reading all bugmail)]

WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

Have you also tried:
- Firefox's safe-mode to exclude extension problems
- a new profile
- a reinstall in a new empty directory ?

Comment 2

[Ria Klaassen (not reading all bugmail)]

Can't replicate this - not a bug in Firefox but probably a bad extension or unclean profile.

Comment 3

[Timwi]

> Can't replicate this - not a bug in Firefox but probably a bad extension

I can reproduce the problem even after disabling all extensions (and restarting). It is therefore not a bad extension.

> or unclean profile.

That /would/ constitute a bug in Firefox.

I'll investigate this further. Please keep the bug open.

Comment 4

[Timwi]

STEPS TO REPRODUCE
==================

- Run Firefox with a new, clean profile
- Navigate to about:config
- Set accessibility.typeaheadfind.linksonly to 'true'
- Navigate to https://bugzilla.mozilla.org/, wait for page to load
- Press Ctrl+U, View Source window appears
- Press Ctrl+F, Find Toolbar appears
- Press 'x'.

Actual Result:
"Phrase not found"

Expected Result:
Should have found the 'x' in '<script type="text/javascript">'

Comment 5

[Roman]

Reproduced on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1) Gecko/20061010 Firefox/2.0

"x" fails, but "xt" finds a match in "text".

Comment 6

[Tae Kim]

This is a bug with find toolbar and not view source. For some reason, find resets the linksonly setting to the default only for the first character. By changing the default to linksonly, the first character entered will search linksonly even on ctrl-f. For example, searching 'x' on this page will only find the 'x' in the link to "Timwi <[e-mail]>" Removing the following lines from nsTypeAheadFind.cpp should fix this.

    // Reset links only to default, if not manually set
    // by the user via ' or / keypress at beginning
    if (!mLinksOnly)
      mLinksOnly = mLinksOnlyPref;

I'm not sure why that is there so unless there's a good reason for the code above, I will submit a patch deleting those lines.

Comment 7

[Tae Kim]

Attachment: delete reset to default linksonly setting

As described in the previous comment, this patch deletes the "reset to default links only setting for the first character" bit. I've tested this for /, ', typing directly, and ctrl-f for both false and true settings of accessibility.typeaheadfind.linksonly without any problems.

Comment 8

[[:Aleksej]]

I see this with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070618 Minefield/3.0a6pre

Looks similar to bug 375171, still confirming because the effect is different.

Comment 9

[Timwi]

The Find function is extremely important and users expect it to be reliable. Also the bug has been open for too long. I think it should block Firefox 3, especially seeing as a patch is available.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

This will not block the final release of Firefox 3.

Comment 11

[Timwi]

Great, yet another major release with a broken Find function. I don't believe it :/

Comment 12

[Timwi]

This is still a problem in RC1, despite a patch being available. Why is the attached patch not being considered?

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 245393 [details] [diff] [review]
delete reset to default linksonly setting

moving to mano since he knows this code much better.

Comment 14

[Asaf Romano (gone)]

Comment on attachment 245393 [details] [diff] [review]
delete reset to default linksonly setting

Maybe I didn't get you comment right.

1. open data:text/html,f<a href="about:blank">foo</a>
2. ctrl+f
3. find "f"

results: it finds the first character, not the link.

Comment 15

[Mike de Boer [:mikedeboer]]

I think bug 375171 provides a good way to fix find-in-page in view-source windows.