359967 - File pref-downloads.dtd is no longer used

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Ton [:Tonnes]]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: 

The file mail/locales/en-US/chrome/mozapps/downloads/pref-downloads.dtd appears to be obsolete and can be deleted.

Reproducible: Always

Comment 1

[Magnus Melin [:mkmelin]]

Seems so... Patch coming up.
http://lxr.mozilla.org/seamonkey/search?string=pref-downloads.dtd
http://lxr.mozilla.org/mozilla1.8/search?string=pref-downloads.dtd

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Removes the unused file.

Comment 3

[Scott MacGregor]

I think the file needs cvs removed as well. Or maybe you need cvs access in order to do that so it shows up in the diff...

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

This includes the actual remove. 'cvsdo remove' and 'patch diff -N' helped.

Comment 5

[Scott MacGregor]

Gavin might be able to help land this.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/locales/en-US/chrome/mozapps/downloads/pref-downloads.dtd delete
mozilla/mail/locales/jar.mn 	1.46

Comment 7

[Scott MacGregor]

Comment on attachment 245327 [details] [diff] [review]
proposed fix, v2

I was going to say no for this on the branch, but I don't think removing an unused file dtd should cause problems for localizers because the file is no longer listed in the jar manifest file.

Approving, but we wouldn't block if this doesn't make it onto the branch.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/locales/en-US/chrome/mozapps/downloads/pref-downloads.dtd (delete)
mozilla/mail/locales/jar.mn 	1.35.2.11