Bugzilla::Search::Saved should have create() and update(), and buglist.cgi should use it

RESOLVED FIXED in Bugzilla 3.0

Status

()

--
enhancement
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: mkanat, Assigned: mkanat)

Tracking

2.23.3
Bugzilla 3.0
Bug Flags:
approval +
blocking3.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
The next step in creating saved reports is that the Saved Search object needs to be able to update the database.
(Assignee)

Updated

12 years ago
Summary: Bugzilla::Search::Saved should have create() and update(), and userprefs.cgi should use it → Bugzilla::Search::Saved should have create() and update(), and buglist.cgi should use it
(Assignee)

Comment 1

12 years ago
Created attachment 245062 [details] [diff] [review]
v1

Okay, I did test this a bit.
Assignee: query-and-buglist → mkanat
Status: NEW → ASSIGNED
Attachment #245062 - Flags: review?(LpSolit)
(Assignee)

Comment 2

12 years ago
Just to make it clear, this is a blocker because it blocks a blocker.
Flags: blocking3.0+

Comment 3

12 years ago
Comment on attachment 245062 [details] [diff] [review]
v1

>Index: Bugzilla/Search/Saved.pm

>+use Bugzilla::Util;

You also have to add |use Bugzilla::Error;| here, else Bugzilla crashes everytime a validator wants to throw an error (such as when entering an invalid query name).

r=LpSolit with this comment fixed.
Attachment #245062 - Flags: review?(LpSolit) → review+

Updated

12 years ago
Flags: approval?
Don't forget to fix the item in comment 3 before checkin.
Flags: approval? → approval+
(Assignee)

Comment 5

12 years ago
Search::Saved appears twice because I did the checkin fix after the original checkin, by mistake.

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.347; previous revision: 1.346
done
Checking in Bugzilla/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v  <--  CGI.pm
new revision: 1.31; previous revision: 1.30
done
Checking in Bugzilla/Constants.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v  <--  Constants.pm
new revision: 1.60; previous revision: 1.59
done
Checking in Bugzilla/Search/Saved.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v  <--  Saved.pm
new revision: 1.2; previous revision: 1.1
done

Checking in Bugzilla/Search/Saved.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v  <--  Saved.pm
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.