Closed
Bug 360028
Opened 18 years ago
Closed 18 years ago
Bugzilla::Search::Saved should have create() and update(), and buglist.cgi should use it
Categories
(Bugzilla :: Query/Bug List, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file)
8.92 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
The next step in creating saved reports is that the Saved Search object needs to be able to update the database.
Assignee | ||
Updated•18 years ago
|
Summary: Bugzilla::Search::Saved should have create() and update(), and userprefs.cgi should use it → Bugzilla::Search::Saved should have create() and update(), and buglist.cgi should use it
Assignee | ||
Comment 1•18 years ago
|
||
Okay, I did test this a bit.
Assignee: query-and-buglist → mkanat
Status: NEW → ASSIGNED
Attachment #245062 -
Flags: review?(LpSolit)
Assignee | ||
Comment 2•18 years ago
|
||
Just to make it clear, this is a blocker because it blocks a blocker.
Flags: blocking3.0+
Comment 3•18 years ago
|
||
Comment on attachment 245062 [details] [diff] [review] v1 >Index: Bugzilla/Search/Saved.pm >+use Bugzilla::Util; You also have to add |use Bugzilla::Error;| here, else Bugzilla crashes everytime a validator wants to throw an error (such as when entering an invalid query name). r=LpSolit with this comment fixed.
Attachment #245062 -
Flags: review?(LpSolit) → review+
Updated•18 years ago
|
Flags: approval?
Comment 4•18 years ago
|
||
Don't forget to fix the item in comment 3 before checkin.
Flags: approval? → approval+
Assignee | ||
Comment 5•18 years ago
|
||
Search::Saved appears twice because I did the checkin fix after the original checkin, by mistake. Checking in buglist.cgi; /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi new revision: 1.347; previous revision: 1.346 done Checking in Bugzilla/CGI.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v <-- CGI.pm new revision: 1.31; previous revision: 1.30 done Checking in Bugzilla/Constants.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Constants.pm,v <-- Constants.pm new revision: 1.60; previous revision: 1.59 done Checking in Bugzilla/Search/Saved.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v <-- Saved.pm new revision: 1.2; previous revision: 1.1 done Checking in Bugzilla/Search/Saved.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Saved.pm,v <-- Saved.pm new revision: 1.3; previous revision: 1.2 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•