Closed Bug 360117 Opened 14 years ago Closed 14 years ago
prototype event dialog : autoexpand freebusy-grid
currently the free/busy-grid displays the set of working hours only. in case an event is displayed that happens to be scheduled outside those hours a small thin selection-bar remains, but the full range of the appointment can't be displayed. in such a case the time-bar and the grid should automatically expand and display the whole range of 24 hours.
This patch handles the auto-expansion of the free/busy-grid in order to display events that have been scheduled outside of the default working hours.
Attachment #245554 - Flags: first-review?(thomas.benisch)
I have two fundamental remarks: 1. Instead of expanding from working hours to 24 hours I would have expected a more dynamic approach, that means to expand the display range only as much as necessary. Example: Working hours from 8:00 to 17:00 New Event scheduled from 18:00 to 19:00 Change display range from 8:00 - 17:00 to 8:00 - 19:00 2. I would have also expected a more dynamic implementation, that means instead of a property force24Hours I would have added a method setStartEndTime(aStartTime,aEndTime). Nevertheless I leave it up to you, if you want to change your implementation. Apart from that, I have not found any issues in your patch.
Comment on attachment 245554 [details] [diff] [review] patch v1 r1=tbe
Attachment #245554 - Flags: first-review?(thomas.benisch) → first-review+
Admittedly it would have been a good idea to allow setting the range of the grid explicitly, but unfortunately I currently don't have the time to change this right now. If need should arise I'll change this sometime later. Checked in on trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.