--with-branding doesn't provide a way of overriding MOZ_APP_DISPLAYNAME

RESOLVED FIXED

Status

()

Firefox
Build Config
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: mconnor, Assigned: Benjamin Smedberg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
This means its harder to have a third branding directory without code changes, which sucks.  I want to add a third branding (Gran Paradiso) to trunk for alphas, while leaving the nightlies as Minefield.
(Assignee)

Comment 1

11 years ago
Created attachment 245109 [details] [diff] [review]
configure.sh, rev. 1
Attachment #245109 - Flags: review?(mconnor)
(Reporter)

Comment 2

11 years ago
Comment on attachment 245109 [details] [diff] [review]
configure.sh, rev. 1

r=me, but as a caveat, this breaks if you have a space, even when quoted.  That's outside of the scope of this bug.

As a note, I landed browser/branding/unofficial with the right files to take advantage of this, if someone wishes to test the patch
Attachment #245109 - Flags: review?(mconnor) → review+
(Assignee)

Comment 3

11 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Blocks: 362209
Is there any chance to checkin this patch onto 1.8 branch?

I mean only the configure.in hack to make %branding_dir%/configure.sh
backwards/forwards compatible ?

+REAL_BRANDING_DIRECTORY="${MOZ_BRANDING_DIRECTORY}"
+
+if test -e "$topsrcdir/$REAL_BRANDING_DIRECTORY/configure.sh"; then
+  . "$topsrcdir/$REAL_BRANDING_DIRECTORY/configure.sh"
+fi
You need to log in before you can comment on or make changes to this bug.