360167 - Launching Chatzilla locks up FireFox

Status: RESOLVED DUPLICATE of bug 353962

(Other Applications :: ChatZilla, defect, P1)

Description

[Travis Robinson]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

About %50 of the time when I click Tools>Chatzilla the whole Firefox browser locks up. Sometimes the initial Chatzilla screen will appear, but it's always on initial launch. It usually requires killing Firefox from the command line or Force Quit option in OSX. If it successfully launches, I have no other difficulties. 
Running OSX 10.4.6 Firefox 2.0 connecting to an IRC server on the local network. Top command (immediately after crash) shows Firefox using 0% cpu

Reproducible: Sometimes

Steps to Reproduce:
1. Launch Firefox
2. Click tools, then click Chatzilla
3.

Actual Results:  
Locked Firefox, requiring a kill from command line


Expected Results:  
Chattzilla to launch

Please feel free to contact me if further info needed.

Comment 1

[James Ross]

Well, technically it can't be a bug in ChatZilla (we only have JS code, and if that 'hangs' you get the Slow Script Dialog), so you'll need to get the stacks from a debug Firefox's threads when it is hung and find out what's going on and what is actually hung, I expect. (It sounds like a race condition, from the only-happens-sometimes part.)

Comment 2

[:Gijs (he/him)]

I'm confirming this as I can reproduce this too, at times - it seems to happen regularly if I try to use it right after I updated from an xpi I built myself, and Firefox restored the session upon restart after using the 'Restart Firefox' button in the Extension manager.

James, you're right that it's not our fault, but I'd like to have it filed at the very least. My debug builds are fscked at the moment, I'll try to get them going again, sometime, uh, next week I guess :\ (busy all weekend).

Comment 3

[:Gijs (he/him)]

radar++

Comment 4

[James Ross]

(In reply to comment #2)
> James, you're right that it's not our fault, but I'd like to have it filed at
> the very least.

I didn't say or mean that it shouldn't be filed, only that the ultimate bug is most likely well outside of ChatZilla's code, and will take global-level debugging to find.

Comment 5

[Alex Vincent [:WeirdAl]]

Attachment: sample from Mac Activity Monitor

Comment 6

[Alex Vincent [:WeirdAl]]

Attachment: multiple threads stack trace

<timeless>	thread 13 looks relevant
	<timeless>	iirc it's fixed on trunk
	<timeless>	basically PEOs don't work properly before trunk
	<mrbkap>	timeless: "proxy event objects"?
	<timeless>	yes
	<timeless>	it requires the event queue service rewrite
	which is an api break
	it can't be done

He also suggests mrbkap or crowder look into this.

Comment 7

[Daniel Veditz [:dveditz]]

Can't realistically block 1.8.1.1 for this, especially if it's going to require the timer rewrite, but do want a fix if we can come up with something in a later release.

Comment 8

[Daniel Veditz [:dveditz]]

What threading changed between 1.8.0 and 1.8? This didn't happen in FF1.5

Comment 9

[James Ross]

Has someone tested the current ChatZilla on FF 1.5?

The most likely code for triggering this has changed since the version around when FF 1.5 was released (although the CZ release it was changed in was released only ~1 month after FF 1.5).

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/irc/js/lib/dcc.js&rev=1.18&mark=141#117

The code in 0.9.68.5 (latest release at FF 1.5 time) let the DNS service pick the callback thread, and so likely wont have involved PEOs like 0.9.69+.

Comment 10

[Robert Ginda]

I just made a quick plugin to disable the call chatzilla is making to the async DNS code.  It seems to make things a little better, but I still sometimes hang on startup :(

The plugin is here: http://www.hacksrus.com/~ginda/chatzilla/scripts/fuck-dcc/init.js

Comment 11

[Robert Ginda]

My plugin hasn't actually helped at all :(  Also, it seems that if I manage to get chatzilla up and running, and I put the laptop to sleep, then the os shuts down abnormally instead.  I'm not sure if it shuts down while going to sleep, or while waking up, but I have to power on the laptop the next time I use it.  Nothing of interest in the console or panic logs.

Someone just popped into #chatzilla and suggested that it was a core duo problem.    He's using XP Home Edition on a core duo, and says, "it never happens to my single core."

Comment 12

[Brendan Eich [:brendan]]

Try 2.0.0.1, or test with latest trunk that includes patch for bug 353962 (rev 3.32 of jslock.h) -- stacks from "multiple threads stack trace" say this is a dup of bug 353962.

/be

Comment 13

[Robert Ginda]

Cool, 2.0.0.1 seems to fix the hang.  It's got way too many other regressions to be a daily browser, but at least we know what the problem is.

Comment 14

[Brendan Eich [:brendan]]

*** This bug has been marked as a duplicate of 353962 ***