360192 - Support error code NS_ERROR_PROXY_CONNECTION_REFUSED with a nicer message than "status 2152398920"

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[:Gijs (he/him)]

As in summary. Will try to do a patch RSN.

Comment 1

[James Ross]

Can you add NS_ERROR_UNKNOWN_PROXY_HOST (http://twpol.dyndns.org/mozilla/misc/nserror?0x804B002A) as well please?

Comment 2

[:Gijs (he/him)]

I was considering doing exactly that, but then I was unable to actually get that error (I set my socks proxy to foobarbazafghafhgosdg.com or somesuch, and it just died with NS_ERROR_FAILURE (2147500037)). Still add it? Am I missing something? (not unlikely at 2am)

Comment 3

[James Ross]

The error only occurs for HTTP proxies, for rather complex and highly undocumented reasons. See: http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsSocketTransport2.cpp#1387 and https://bugzilla.mozilla.org/show_bug.cgi?id=226943#c10 for what there is.

Comment 4

[:Gijs (he/him)]

Attachment: Patch

Ah, that explains it. I could reproduce with that bit of help, and I've added that error too. Patch has been tested, works fine afaict. r? from you, then. :-)

Comment 5

[James Ross]

Comment on attachment 245167 [details] [diff] [review]
Patch

I kinda wish we could show more info for the errors (like the host that failed the lookup or the proxy that refused the connection), but I don't think we can trivially get that.

r=silver as is.

Comment 6

[:Gijs (he/him)]

Checking in mozilla/extensions/irc/js/lib/connection-xpcom.js;
/cvsroot/mozilla/extensions/irc/js/lib/connection-xpcom.js,v  <--  connection-xpcom.js
new revision: 1.42; previous revision: 1.41
done
Checking in mozilla/extensions/irc/xul/content/handlers.js;
/cvsroot/mozilla/extensions/irc/xul/content/handlers.js,v  <--  handlers.js
new revision: 1.139; previous revision: 1.138
done
Checking in mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties;
/cvsroot/mozilla/extensions/irc/xul/locale/en-US/chatzilla.properties,v  <--  chatzilla.properties
new revision: 1.123; previous revision: 1.122
done