360214 - cairo Mac OS X builds have broken select widget rendering

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Josh Aas]

Cairo Mac OS X builds have broken select widget rendering. The box on the right with the triangle is missing.

Comment 1

[Josh Aas]

Attachment: screenshot

Comment 2

[Josh Aas]

*** Bug 360215 has been marked as a duplicate of this bug. ***

Comment 3

[Stuart Parmenter]

vlad?  are we even doing native form controls?

Comment 4

[Josh Aas]

Native form controls are turned off for now. We plan to do native form controls soon.

Comment 5

[Josh Aas]

It looks like this never worked under cairo. I went pretty far back in nightly builds of cairo mac firefox and they're all broken this way.

Comment 6

[Josh Aas]

Attachment: fix v1.0

Layout uses the scrollbar width from the device context to determine how wide to make the select button. The thebes device context uses an nsLookAndFeel metric to determine scrollbar width instead of hardcoding a value like the mac device context does (we don't use the mac device context under cairo, we use thebes). The fix is to add the metric to our look and feel code on mac.

Comment 7

[Mark Mentovai]

Comment on attachment 245257 [details] [diff] [review]
fix v1.0

Prefer ::GetThemeMetric(kThemeMetricScrollBarWidth, &value)

Comment 8

[Josh Aas]

The native metric function returns 15, we've always used 16. I'd prefer to leave it the way it has always been until we can audit to make sure things will match up. I will add a comment about it.

Comment 9

[Josh Aas]

landed on trunk