360239 - [Proto] Repeat until recurrence -> wrong default date

Status: RESOLVED WORKSFORME

(Calendar :: Lightning Only, defect)

Description

[Andreas Treumann]

REPRODUCTION:
=============

- create a new event in the future and open the custom recurrence dialog
- the default date of 'Repeat until' is the current day 


RESULT:
=======

- the created recurrence rule makes no sense.

EXPECTED RESULT:
================

- the default date should be the date of the new created event

REPRODUCIBLE:
=============

- always

Comment 1

[Michael Büttner (no reviews TFN)]

> the default date should be the date of the new created event
admittedly selecting a better default prevents the default case, but it doesn't solve the problem completely. it doesn't prevent the user from manually entering a date that has already passed. as a result the first occurrence will still just disappear from the view. christian, any comments on this? it seems that this a case where we'd most probably come up with an error message. any other suggestions?

Comment 2

[Christian Jansen]

First, we should be have as suggested. The default date should be the date of the new created event.

Regarding the second issue. Well, I think it is Ok that users can manually
enter a date that has already passed. I wouldn't display a message here.

Comment 3

[Andreas Treumann]

If you enter a already passed date the plain text of the pattern is wrong. You get something like this: Occurs every day effective 11/14/06 until 11/09/06 from 10:30 to 13:00. Thats was I mean with "RESULT: - the created recurrence rule makes no sense."

Comment 4

[Michael Büttner (no reviews TFN)]

(In reply to comment #2)
> Regarding the second issue. Well, I think it is Ok that users can manually
> enter a date that has already passed. I wouldn't display a message here.
In case you save such an event it will disappear from the views, no change to get it back, it will simply be lost. I don't think this is something that should be allowed to happen.

Comment 5

[Daniel Boelzle [:dbo]]

(In reply to comment #4)
> (In reply to comment #2)
> > Regarding the second issue. Well, I think it is Ok that users can manually
> > enter a date that has already passed. I wouldn't display a message here.
> In case you save such an event it will disappear from the views, no change to
> get it back, it will simply be lost. I don't think this is something that
> should be allowed to happen.

Yes, and moreover it bloats the data storage without any sense. I consider events without any occurrence being invalid. The providers could figure that out, but better the frontend code makes sure those can't be saved at all.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Oh, crap, sorry, moving back, send hatemail to this address.

Comment 7

[Stefan Sitter [:ssitter]]

Works for me using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/20080521 Calendar/0.9pre. The default until date is the same as the start date.

I'd suggest to file a new bug for the 'user can set until date before start date' issue. Currently such an event will just be displayed on the start date.

Comment 8

[Omar Bajraszewski]

Works for me using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081010 Calendar/1.0pre

Comment 9

[Simon Paquet [:sipaq]]

Andreas, could you please test, whether you still see this on latest Lightning nightly builds?

Comment 10

[Andreas Treumann]

Checked in nightly build 20081103050551 -> WFM.