360269 - Useless and questionable code tidyup

Status: RESOLVED INVALID

(Thunderbird :: Address Book, defect)

Description

[Paul Tomlin]

Just a few oddities I noticed


Questionable braces
http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/content/abContactsPanel.js#55

Useless return;
http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/content/abCommon.js#741
http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/content/addressbook.js#512
http://lxr.mozilla.org/seamonkey/source/mail/components/addrbook/content/addressbook.js#559
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/content/abSelectAddressesDialog.js#417
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/content/addressbook.js#496
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/resources/content/addressbook.js#543

Questionable return;, probably a formatting nicety
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/src/nsAbLDAPAttributeMap.js#193
http://lxr.mozilla.org/seamonkey/source/mailnews/addrbook/src/nsAbLDAPAttributeMap.js#219

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Not really sure but aren't the returns used to eliminate the strict JavaScript warning about a function not always returning a value?

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Some of the points in comment #0 aren't really valid anymore since the code has changed significantly, is this issue still valid?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Some of the points in comment #0 aren't really valid anymore since the code has
> changed significantly, is this issue still valid?
> 

Given the age of this bug, I'm going to resolve this as Invalid. Normally we'd do tidy up as we go. Paul, if you do want to submit a patch for this, please feel free to re-open and attach.