360275 - 64-bit - remove usage of va_list, change func sig to return Atom instead of int

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Werner Sharp]

The usage is va_list was a convenience that was only used on some platforms to layout arguments and was not used for calling vararg C++ functions.   64-bit has a completely different mechansim (register usage + stack) and does not tolerate our va_list usage.  Switched over to use a uint32 *arg array everywhere.  (This memory contains both native types and Atom at different points in time)

Changed our interp/verify/jitted function signature to return Atom instead of int.   In 64-bit, int won't fit an Atom so this change is required.

Tweak avmshell code to get it working on OSX 10.5.

Comment 1

[Werner Sharp]

Attachment: code change patch

Tested these changes with ASC sanity tests on Mac and Win

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Our practice is for someone other than the patch author to provide review.  You should request review from someone by setting the flag to "?" in the edit interface, and then entering the reviewer's email in the field next to it.

Thanks!

Comment 3

[Steven Johnson]

Comment on attachment 245226 [details] [diff] [review]
code change patch

minor bug on line 203 needs correction: doubleToAtom() call missing

Comment 4

[Werner Sharp]

Attachment: updated patch - doubleToAtom restored. Change 4 into sizeof(uint32)

Comment 5

[Steven Johnson]

Comment on attachment 245237 [details] [diff] [review]
updated patch - doubleToAtom restored.  Change 4 into sizeof(uint32)

r=stejohns

Comment 6

[Chris Peyer]

Transfer Bug from Core->Tamarin to Tamarin Product.

Comment 7

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to
verified.