360291 - Make nodes implement nsISupportsWeakReference

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Smaug needed this for a couple of his bugs, and I've needed this in the past too, so we should just do it. Is possible that we sometime in the future might fix these things with graydons cycle collector, but we can always revert at that point. I suspect that's quite a bit off though since a lot of code will have to be converted to it.

Anyhow, this makes all nodes implement nsISupportsWeakReference. Not sure if we technically need it on attribute nodes, but it may be nice to be able to rely on that anything implementing nsI(DOM)Node also implements nsISupportsWeakReference.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

This should do it. Documents already use nsSupportsWeakReference, and it may be a good idea to let them use that since they seem to be QIed to nsISupportsWeakReference often enough that it's nice to avoid creating the tearoff every time.

Comment 2

[Boris Zbarsky [:bzbarsky]]

> but it may be nice to be able to rely on that anything implementing
> nsI(DOM)Node also implements nsISupportsWeakReference.

Can't rely on the nsIDOMNode part of that anyway -- any random JSObject will implement nsIDOMNode thanks to XPConnect.  The nsINode part might be nice, yes.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 245243 [details] [diff] [review]
Patch to fix

r+sr=jst

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Update to tip

This is what I landed

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in, thanks for the quick review.