Closed Bug 360301 Opened 13 years ago Closed 13 years ago

Fail to remove mouse handlers from tree when dragging columns

Categories

(Toolkit :: XUL Widgets, defect)

1.8 Branch
x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

Details

(Keywords: fixed1.8.1.1)

Attachments

(1 file, 1 obsolete file)

The binding for trees (tree.xml) adds a mousemove and mouseup handler when you drag a column. It is added with "false" as the last arg and removed with "true" as the last arg, which causes it to not be removed since capture and bubble event listeners are stored in differenct voidarrays

Changing it to remove "false" fixes the issue. That assumes of course that we want to capture the mouse events on bubble, not capture. Which I think makes sense.


Patch upcoming.
Attached patch match add/remove calls (obsolete) — Splinter Review
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #245279 - Flags: first-review?(bugs)
Attachment #245279 - Flags: approval1.8.1.1?
Comment on attachment 245279 [details] [diff] [review]
match add/remove calls

Need reviewed, trunk-landed patch before you ask for branch approvals.

Trying a different reviewer, but you may want to ask in #developers who's reviewing XBL widgets these days.
Attachment #245279 - Flags: first-review?(enndeakin)
Attachment #245279 - Flags: first-review?(bugs)
Attachment #245279 - Flags: approval1.8.1.1?
Attachment #245279 - Flags: approval1.8.1.1-
Attachment #245279 - Flags: first-review?(enndeakin) → first-review+
Makes more sense to have them all be capturing, per Neil's request.
Attachment #245279 - Attachment is obsolete: true
Attachment #247104 - Flags: first-review?(enndeakin)
Comment on attachment 247104 [details] [diff] [review]
make them all capturing, to follow rest of listeners in file

Sure, although you were referring to the other Neil right?
Attachment #247104 - Flags: first-review?(enndeakin) → first-review+
Checked in on Trunk 12/1

Whoops, didn't realize Neil Deakin != Neil. Sorry for the confusion (mostly mine).
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 247104 [details] [diff] [review]
make them all capturing, to follow rest of listeners in file

Okay, now I have my reviewed trunk-landed patch. :-) Hoping there isn't a default "baking" period.
Attachment #247104 - Flags: approval1.8.1.1?
Comment on attachment 247104 [details] [diff] [review]
make them all capturing, to follow rest of listeners in file

Approved for 1.8 branch, a=jay for drivers.  Please land ASAP as code freeze is today.  Thanks!
Attachment #247104 - Flags: approval1.8.1.1? → approval1.8.1.1+
checked in 1.8 branch 12/1
You need to log in before you can comment on or make changes to this bug.