Mutiple identical "dl-done" notifications sent when using Save page as - Web page, Complete

RESOLVED INCOMPLETE

Status

()

Toolkit
Downloads API
RESOLVED INCOMPLETE
12 years ago
10 years ago

People

(Reporter: Devon Jensen, Unassigned)

Tracking

1.8 Branch
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: CLOSEME 07/14)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

The firefox downloading backend sends out notifications to observers when a download completes.  "dl-done"

This works fine for single downloads, but when saving a complete web page, multiple identical dl-done notifications are sent.

I assume that a "dl-done" notification goes out for every accessory file (images, scripts, etc) that is saved into the accompanying folder when saving a complete web page.  One problem is that all of these point to the same original htm/html file that was saved, not to the particular accessory file.  (ie the subject in the dl-done notification is the original htm/html file)

This is a problem for observers that want to do something with the newly downloaded file, like send it to a virus scan.  As it is, the htm file gets repeatedly scanned, not each individual file that is downloaded into the accessory folder

Reproducible: Always

Steps to Reproduce:
I'm testing this with download statusbar's virus scan feature

1. In download statusbar's options, set up a program to send the newly downloaded file uri to, a virus scanner, a zip program, whatever
2. Select Save page as from the File menu.  Make sure that web page, complete is selected in the Save file window



Expected Results:  
I don't know whether you want to inject the actual file uri of each accessory file into the subject of the dl-done notification,

or, 

just make sure that dl-done notification is only sent once for the original htm file that was saved - this might be easier for now
Reporter, do you still see this problem with the latest Firefox 2? If not, can you please close this bug as WORKSFORME. Thanks!
Whiteboard: CLOSEME 07/14
Version: unspecified → 2.0 Branch
(Reporter)

Comment 2

11 years ago
Yes, still a problem
What is your firefox user agent string (Do help > about and copy&paste the line starting with 'mozilla')

Does this happen if you make a new firefox profile?
- http://kb.mozillazine.org/Profile_manager
(Note: Do not delete your existing profile)
(Reporter)

Comment 4

11 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4

This is a problem with the core download manager, not a extension or profile issue.  The extension in this case only makes the problem apparent.  As it happens, this doesn't really cause issue with a vanilla firefox 2.0 because it doesn't do much with the 'dl-done' notification, but it could cause issues in future versions.  

CCing sdwilsh - hope he doesn't mind

I haven't tested this on the trunk, but I doubt it was fixed in the DM conversion to sqlite
I get e-mails anyway because I watch the QA contact ;)

I suppose it all depends on how the save complete page works.  If it is creating an nsITransferable for each file, then this will absolutely happen.  If it doesn't, I'm not sure how it'd be sending the notification out.
Resolving old UNCONFIRMED Download Manager bugs as INCOMPLETE.  If you still see this issue, please reopen.

To mark all these bug changes as read, filter on ONOMATOPOEIA.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → INCOMPLETE
(Assignee)

Updated

10 years ago
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.