360332 - Search <Engine> for <String> context menu option doesn't support Ctrl/Shift/Middle clicks

Status: VERIFIED FIXED

(Firefox :: Search, enhancement, P5)

Description

[Ben Basson]

Some menu items that spawn new tabs support the modifiers Ctrl/Shift and middle clicking in order to determine tab focus. Prime examples would be the History and Bookmarks menus. Search <Engine> for <String> on the context menu does not.

I've done this in my Context Search extension and can probably write a patch for this if anyone is willing to cover QA duties.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I'm not sure if this is desired. Do other context menu items support these?

Comment 2

[Mycroft Project (CC)]

(In reply to comment #1)
> I'm not sure if this is desired. Do other context menu items support these?
> 

Not sure if it's definitive or not (it was the only thing I could find where it made any sense...) but 'View Background Image' allows Ctrl/Shift and middle clicking.

Comment 3

[Ben Basson]

View Image and View Background Image both support the modifier. Jesse pushed for a bunch of these changes a good while back to address the inconsistencies with these menu items and bookmarks, etc.

Comment 5

[quasicomputational]

Ctrl- and shift-click seem to work these days, but middle-click still doesn't.

Comment 6

[Patrick Storz]

Attachment: Bug 360332 - Enable modifiers / middle click for context search. r?jaws

Allows to perform the search in a new foreground/background tab or
a new window using modifiers or middle mouse button.

Introduces a certain level of consistency with other entries in
the context menu, like navigation and "view image".

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50e18cc32331
Enable modifiers / middle click for context search. r=Standard8

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/50e18cc32331

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using Fx88.0b9 and Fx89.0a1 on Windows 10, Ubuntu 18.04 and macOS 11.2. The CTRL/SHIFT/Middle Click are enabled for the "Search <Engine> for <String>" options.