nsIAbMDBCard::CopyCard is unused.

RESOLVED FIXED

Status

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({memory-footprint})

Trunk
memory-footprint

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
According to lxr (http://lxr.mozilla.org/seamonkey/search?string=CopyCard) nsIAbMDBCard::CopyCard is never used. Additionally, its got some nasty copy and paste from nsIAbCard::Copy. Hence I think we can drop it.
(Assignee)

Comment 1

12 years ago
Created attachment 245408 [details] [diff] [review]
Removes nsIAbMDBCard::CopyCard

This removes the largely copy and pasted function CopyCard from nsIAbMDBCard. I've also ensured that we initalise a copy of variables correctly in nsIAbCard::Copy based on what was in CopyCard.
Attachment #245408 - Flags: superreview?(bienvenu)
Attachment #245408 - Flags: review?(bienvenu)

Comment 2

12 years ago
Comment on attachment 245408 [details] [diff] [review]
Removes nsIAbMDBCard::CopyCard

r/sr=bienvenu - but if we want to support copying cards to the clipboard, would this function then become useful?
Attachment #245408 - Flags: superreview?(bienvenu)
Attachment #245408 - Flags: superreview+
Attachment #245408 - Flags: review?(bienvenu)
Attachment #245408 - Flags: review+
(Assignee)

Comment 3

12 years ago
(In reply to comment #2)
> (From update of attachment 245408 [details] [diff] [review] [edit])
> r/sr=bienvenu - but if we want to support copying cards to the clipboard, would
> this function then become useful?

If it did, then we should use the generic nsIAbCard::Copy, and possibly extend that down into the nsAb*Card for database specific functions. If we left nsIAbMDBCard::CopyCard and used that, then we'd have a mdb specific stuff which means copy wouldn't work for outlook, ldap etc.
(Assignee)

Comment 4

12 years ago
Patch checked in
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.