According to lxr (http://lxr.mozilla.org/seamonkey/search?string=CopyCard) nsIAbMDBCard::CopyCard is never used. Additionally, its got some nasty copy and paste from nsIAbCard::Copy. Hence I think we can drop it.
Created attachment 245408 [details] [diff] [review] Removes nsIAbMDBCard::CopyCard This removes the largely copy and pasted function CopyCard from nsIAbMDBCard. I've also ensured that we initalise a copy of variables correctly in nsIAbCard::Copy based on what was in CopyCard.
Comment on attachment 245408 [details] [diff] [review] Removes nsIAbMDBCard::CopyCard r/sr=bienvenu - but if we want to support copying cards to the clipboard, would this function then become useful?
(In reply to comment #2) > (From update of attachment 245408 [details] [diff] [review] ) > r/sr=bienvenu - but if we want to support copying cards to the clipboard, would > this function then become useful? If it did, then we should use the generic nsIAbCard::Copy, and possibly extend that down into the nsAb*Card for database specific functions. If we left nsIAbMDBCard::CopyCard and used that, then we'd have a mdb specific stuff which means copy wouldn't work for outlook, ldap etc.
Patch checked in
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.