360492 - nsIAbMDBCard::CopyCard is unused.

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

According to lxr (http://lxr.mozilla.org/seamonkey/search?string=CopyCard) nsIAbMDBCard::CopyCard is never used. Additionally, its got some nasty copy and paste from nsIAbCard::Copy. Hence I think we can drop it.

Comment 1

[Mark Banner (:standard8)]

Attachment: Removes nsIAbMDBCard::CopyCard

This removes the largely copy and pasted function CopyCard from nsIAbMDBCard. I've also ensured that we initalise a copy of variables correctly in nsIAbCard::Copy based on what was in CopyCard.

Comment 2

[David :Bienvenu]

Comment on attachment 245408 [details] [diff] [review]
Removes nsIAbMDBCard::CopyCard

r/sr=bienvenu - but if we want to support copying cards to the clipboard, would this function then become useful?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> (From update of attachment 245408 [details] [diff] [review] [edit])
> r/sr=bienvenu - but if we want to support copying cards to the clipboard, would
> this function then become useful?

If it did, then we should use the generic nsIAbCard::Copy, and possibly extend that down into the nsAb*Card for database specific functions. If we left nsIAbMDBCard::CopyCard and used that, then we'd have a mdb specific stuff which means copy wouldn't work for outlook, ldap etc.

Comment 4

[Mark Banner (:standard8)]

Patch checked in