Closed Bug 360579 Opened 18 years ago Closed 18 years ago

[FIX]Fix for bug 326009 doesn't work quite right with more than 2 tabs

Categories

(SeaMonkey :: Tabbed Browser, defect, P1)

Product:
SeaMonkey
Component:
Tabbed Browser
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.0a1

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: fixed1.8.1.1, memory-leak)

Attachments

(1 file)

Fix
1.38 KB, patch
jst
: review+
jst
: superreview+
dveditz
: approval1.8.1.1+
Details | Diff | Splinter Review 
See bug 121377 comment 19.  The basic problem is that we find the right tab... but then keep looking.

So not only is the behavior wrong, but we leak the docshell too.

Trivial fix coming up.
I think the leak makes this worth fixing on the branch.  The fix is tiny and very safe.
Flags: blocking1.8.1.1?
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
Attached patch Fix — — Splinter Review 

        Attachment #245463 -
        Flags: superreview?(jst)

        Attachment #245463 -
        Flags: review?(jst)

    
    

    
  
Comment on attachment 245463 [details] [diff] [review]
Fix

Yeah, this is obviously the right thing to do. r+sr=jst

        Attachment #245463 -
        Flags: superreview?(jst)

        Attachment #245463 -
        Flags: superreview+

        Attachment #245463 -
        Flags: review?(jst)

        Attachment #245463 -
        Flags: review+

    
    

    
  
Comment on attachment 245463 [details] [diff] [review]
Fix

Requesting branch approval.  This fixes a probably-not-uncommon leak, in addition to the correctness fix.

        Attachment #245463 -
        Flags: approval1.8.1.1?

    
    

    
  
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
  
Flags: in-testsuite?
Flags: blocking1.8.1.1? → blocking1.8.1.1+

    
    

    
  
Comment on attachment 245463 [details] [diff] [review]
Fix

approved for 1.8 branch, a=dveditz for drivers

        Attachment #245463 -
        Flags: approval1.8.1.1? → approval1.8.1.1+

    
    

    
  
Fixed for 1.8.1.1.
Keywords: fixed1.8.1.1
Product: Core → SeaMonkey

    
  
Target Milestone: mozilla1.9alpha1 → seamonkey2.0a1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: