[FIX]Fix for bug 326009 doesn't work quite right with more than 2 tabs

RESOLVED FIXED in seamonkey2.0a1

Status

P1
major
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

({fixed1.8.1.1, memory-leak})

Trunk
seamonkey2.0a1
x86
Linux
fixed1.8.1.1, memory-leak
Bug Flags:
blocking1.8.1.1 +
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
See bug 121377 comment 19.  The basic problem is that we find the right tab... but then keep looking.

So not only is the behavior wrong, but we leak the docshell too.

Trivial fix coming up.
(Assignee)

Comment 1

12 years ago
I think the leak makes this worth fixing on the branch.  The fix is tiny and very safe.
Flags: blocking1.8.1.1?
Priority: -- → P1
Target Milestone: --- → mozilla1.9alpha
(Assignee)

Comment 2

12 years ago
Created attachment 245463 [details] [diff] [review]
Fix
Attachment #245463 - Flags: superreview?(jst)
Attachment #245463 - Flags: review?(jst)
Comment on attachment 245463 [details] [diff] [review]
Fix

Yeah, this is obviously the right thing to do. r+sr=jst
Attachment #245463 - Flags: superreview?(jst)
Attachment #245463 - Flags: superreview+
Attachment #245463 - Flags: review?(jst)
Attachment #245463 - Flags: review+
(Assignee)

Comment 4

12 years ago
Comment on attachment 245463 [details] [diff] [review]
Fix

Requesting branch approval.  This fixes a probably-not-uncommon leak, in addition to the correctness fix.
Attachment #245463 - Flags: approval1.8.1.1?
(Assignee)

Comment 5

12 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Flags: in-testsuite?
Flags: blocking1.8.1.1? → blocking1.8.1.1+
Comment on attachment 245463 [details] [diff] [review]
Fix

approved for 1.8 branch, a=dveditz for drivers
Attachment #245463 - Flags: approval1.8.1.1? → approval1.8.1.1+
(Assignee)

Comment 7

12 years ago
Fixed for 1.8.1.1.
Keywords: fixed1.8.1.1
Product: Core → SeaMonkey

Updated

10 years ago
Target Milestone: mozilla1.9alpha1 → seamonkey2.0a1
You need to log in before you can comment on or make changes to this bug.